-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35986/
-----------------------------------------------------------

(Updated July 7, 2015, 6:26 p.m.)


Review request for mesos, Adam B and Isabel Jimenez.


Bugs: MESOS-2868
    https://issues.apache.org/jira/browse/MESOS-2868


Repository: mesos


Description
-------

Allow slave attributes flag take a value with ':'.


Diffs (updated)
-----

  Makefile.am f8e958d376efa55ace7c5727a31b8e747403641e 
  configure.ac 546c9bbf775a4ef481fafb3a58c85c6d80e19500 
  docs/ec2-scripts.md PRE-CREATION 
  docs/persistent-volume.md e3dfe6d785bbfda2489ba5d71cad043f290fb23a 
  docs/tools.md 09619f2c162b1765e7718fc314e77b0f77148b97 
  docs/using-the-mesos-submit-tool.md PRE-CREATION 
  ec2/Makefile.am PRE-CREATION 
  ec2/deploy.amazon64-old/root/ephemeral-hdfs/conf/core-site.xml PRE-CREATION 
  ec2/deploy.amazon64-old/root/ephemeral-hdfs/conf/hadoop-env.sh PRE-CREATION 
  ec2/deploy.amazon64-old/root/ephemeral-hdfs/conf/hdfs-site.xml PRE-CREATION 
  ec2/deploy.amazon64-old/root/ephemeral-hdfs/conf/mapred-site.xml PRE-CREATION 
  ec2/deploy.amazon64-old/root/ephemeral-hdfs/conf/masters PRE-CREATION 
  ec2/deploy.amazon64-old/root/ephemeral-hdfs/conf/slaves PRE-CREATION 
  ec2/deploy.amazon64-old/root/mesos-ec2/cluster-url PRE-CREATION 
  ec2/deploy.amazon64-old/root/mesos-ec2/copy-dir PRE-CREATION 
  ec2/deploy.amazon64-old/root/mesos-ec2/create-swap PRE-CREATION 
  ec2/deploy.amazon64-old/root/mesos-ec2/hadoop-framework-conf/core-site.xml 
PRE-CREATION 
  ec2/deploy.amazon64-old/root/mesos-ec2/hadoop-framework-conf/hadoop-env.sh 
PRE-CREATION 
  ec2/deploy.amazon64-old/root/mesos-ec2/hadoop-framework-conf/mapred-site.xml 
PRE-CREATION 
  ec2/deploy.amazon64-old/root/mesos-ec2/haproxy+apache/haproxy.config.template 
PRE-CREATION 
  ec2/deploy.amazon64-old/root/mesos-ec2/hypertable/Capfile PRE-CREATION 
  ec2/deploy.amazon64-old/root/mesos-ec2/hypertable/hypertable.cfg PRE-CREATION 
  ec2/deploy.amazon64-old/root/mesos-ec2/masters PRE-CREATION 
  ec2/deploy.amazon64-old/root/mesos-ec2/mesos-daemon PRE-CREATION 
  ec2/deploy.amazon64-old/root/mesos-ec2/redeploy-mesos PRE-CREATION 
  ec2/deploy.amazon64-old/root/mesos-ec2/setup PRE-CREATION 
  ec2/deploy.amazon64-old/root/mesos-ec2/setup-slave PRE-CREATION 
  ec2/deploy.amazon64-old/root/mesos-ec2/setup-torque PRE-CREATION 
  ec2/deploy.amazon64-old/root/mesos-ec2/slaves PRE-CREATION 
  ec2/deploy.amazon64-old/root/mesos-ec2/ssh-no-keychecking PRE-CREATION 
  ec2/deploy.amazon64-old/root/mesos-ec2/start-hypertable PRE-CREATION 
  ec2/deploy.amazon64-old/root/mesos-ec2/start-mesos PRE-CREATION 
  ec2/deploy.amazon64-old/root/mesos-ec2/stop-hypertable PRE-CREATION 
  ec2/deploy.amazon64-old/root/mesos-ec2/stop-mesos PRE-CREATION 
  ec2/deploy.amazon64-old/root/mesos-ec2/zoo PRE-CREATION 
  ec2/deploy.amazon64-old/root/persistent-hdfs/conf/core-site.xml PRE-CREATION 
  ec2/deploy.amazon64-old/root/persistent-hdfs/conf/hadoop-env.sh PRE-CREATION 
  ec2/deploy.amazon64-old/root/persistent-hdfs/conf/hdfs-site.xml PRE-CREATION 
  ec2/deploy.amazon64-old/root/persistent-hdfs/conf/mapred-site.xml 
PRE-CREATION 
  ec2/deploy.amazon64-old/root/persistent-hdfs/conf/masters PRE-CREATION 
  ec2/deploy.amazon64-old/root/persistent-hdfs/conf/slaves PRE-CREATION 
  ec2/deploy.amazon64-old/root/spark/conf/spark-env.sh PRE-CREATION 
  ec2/deploy.amazon64/root/ephemeral-hdfs/conf/core-site.xml PRE-CREATION 
  ec2/deploy.amazon64/root/ephemeral-hdfs/conf/hadoop-env.sh PRE-CREATION 
  ec2/deploy.amazon64/root/ephemeral-hdfs/conf/hdfs-site.xml PRE-CREATION 
  ec2/deploy.amazon64/root/ephemeral-hdfs/conf/mapred-site.xml PRE-CREATION 
  ec2/deploy.amazon64/root/ephemeral-hdfs/conf/masters PRE-CREATION 
  ec2/deploy.amazon64/root/ephemeral-hdfs/conf/slaves PRE-CREATION 
  ec2/deploy.amazon64/root/mesos-ec2/cluster-url PRE-CREATION 
  ec2/deploy.amazon64/root/mesos-ec2/copy-dir PRE-CREATION 
  ec2/deploy.amazon64/root/mesos-ec2/create-swap PRE-CREATION 
  ec2/deploy.amazon64/root/mesos-ec2/hadoop-framework-conf/core-site.xml 
PRE-CREATION 
  ec2/deploy.amazon64/root/mesos-ec2/hadoop-framework-conf/hadoop-env.sh 
PRE-CREATION 
  ec2/deploy.amazon64/root/mesos-ec2/hadoop-framework-conf/mapred-site.xml 
PRE-CREATION 
  ec2/deploy.amazon64/root/mesos-ec2/haproxy+apache/haproxy.config.template 
PRE-CREATION 
  ec2/deploy.amazon64/root/mesos-ec2/hypertable/Capfile PRE-CREATION 
  ec2/deploy.amazon64/root/mesos-ec2/hypertable/hypertable.cfg PRE-CREATION 
  ec2/deploy.amazon64/root/mesos-ec2/masters PRE-CREATION 
  ec2/deploy.amazon64/root/mesos-ec2/mesos-daemon PRE-CREATION 
  ec2/deploy.amazon64/root/mesos-ec2/redeploy-mesos PRE-CREATION 
  ec2/deploy.amazon64/root/mesos-ec2/setup PRE-CREATION 
  ec2/deploy.amazon64/root/mesos-ec2/setup-slave PRE-CREATION 
  ec2/deploy.amazon64/root/mesos-ec2/setup-torque PRE-CREATION 
  ec2/deploy.amazon64/root/mesos-ec2/slaves PRE-CREATION 
  ec2/deploy.amazon64/root/mesos-ec2/ssh-no-keychecking PRE-CREATION 
  ec2/deploy.amazon64/root/mesos-ec2/start-hypertable PRE-CREATION 
  ec2/deploy.amazon64/root/mesos-ec2/start-mesos PRE-CREATION 
  ec2/deploy.amazon64/root/mesos-ec2/stop-hypertable PRE-CREATION 
  ec2/deploy.amazon64/root/mesos-ec2/stop-mesos PRE-CREATION 
  ec2/deploy.amazon64/root/mesos-ec2/zoo PRE-CREATION 
  ec2/deploy.amazon64/root/persistent-hdfs/conf/core-site.xml PRE-CREATION 
  ec2/deploy.amazon64/root/persistent-hdfs/conf/hadoop-env.sh PRE-CREATION 
  ec2/deploy.amazon64/root/persistent-hdfs/conf/hdfs-site.xml PRE-CREATION 
  ec2/deploy.amazon64/root/persistent-hdfs/conf/mapred-site.xml PRE-CREATION 
  ec2/deploy.amazon64/root/persistent-hdfs/conf/masters PRE-CREATION 
  ec2/deploy.amazon64/root/persistent-hdfs/conf/slaves PRE-CREATION 
  ec2/deploy.amazon64/root/spark/conf/spark-env.sh PRE-CREATION 
  ec2/deploy.centos64/root/ephemeral-hdfs/conf/core-site.xml PRE-CREATION 
  ec2/deploy.centos64/root/ephemeral-hdfs/conf/hadoop-env.sh PRE-CREATION 
  ec2/deploy.centos64/root/ephemeral-hdfs/conf/hdfs-site.xml PRE-CREATION 
  ec2/deploy.centos64/root/ephemeral-hdfs/conf/mapred-site.xml PRE-CREATION 
  ec2/deploy.centos64/root/ephemeral-hdfs/conf/masters PRE-CREATION 
  ec2/deploy.centos64/root/ephemeral-hdfs/conf/slaves PRE-CREATION 
  ec2/deploy.centos64/root/mesos-ec2/cluster-url PRE-CREATION 
  ec2/deploy.centos64/root/mesos-ec2/copy-dir PRE-CREATION 
  ec2/deploy.centos64/root/mesos-ec2/create-swap PRE-CREATION 
  ec2/deploy.centos64/root/mesos-ec2/hadoop-framework-conf/core-site.xml 
PRE-CREATION 
  ec2/deploy.centos64/root/mesos-ec2/hadoop-framework-conf/hadoop-env.sh 
PRE-CREATION 
  ec2/deploy.centos64/root/mesos-ec2/hadoop-framework-conf/mapred-site.xml 
PRE-CREATION 
  ec2/deploy.centos64/root/mesos-ec2/haproxy+apache/haproxy.config.template 
PRE-CREATION 
  ec2/deploy.centos64/root/mesos-ec2/hypertable/Capfile PRE-CREATION 
  ec2/deploy.centos64/root/mesos-ec2/hypertable/hypertable.cfg PRE-CREATION 
  ec2/deploy.centos64/root/mesos-ec2/masters PRE-CREATION 
  ec2/deploy.centos64/root/mesos-ec2/mesos-daemon PRE-CREATION 
  ec2/deploy.centos64/root/mesos-ec2/redeploy-mesos PRE-CREATION 
  ec2/deploy.centos64/root/mesos-ec2/setup PRE-CREATION 
  ec2/deploy.centos64/root/mesos-ec2/setup-slave PRE-CREATION 
  ec2/deploy.centos64/root/mesos-ec2/setup-torque PRE-CREATION 
  ec2/deploy.centos64/root/mesos-ec2/slaves PRE-CREATION 
  ec2/deploy.centos64/root/mesos-ec2/ssh-no-keychecking PRE-CREATION 
  ec2/deploy.centos64/root/mesos-ec2/start-hypertable PRE-CREATION 
  ec2/deploy.centos64/root/mesos-ec2/start-mesos PRE-CREATION 
  ec2/deploy.centos64/root/mesos-ec2/stop-hypertable PRE-CREATION 
  ec2/deploy.centos64/root/mesos-ec2/stop-mesos PRE-CREATION 
  ec2/deploy.centos64/root/mesos-ec2/zoo PRE-CREATION 
  ec2/deploy.centos64/root/persistent-hdfs/conf/core-site.xml PRE-CREATION 
  ec2/deploy.centos64/root/persistent-hdfs/conf/hadoop-env.sh PRE-CREATION 
  ec2/deploy.centos64/root/persistent-hdfs/conf/hdfs-site.xml PRE-CREATION 
  ec2/deploy.centos64/root/persistent-hdfs/conf/mapred-site.xml PRE-CREATION 
  ec2/deploy.centos64/root/persistent-hdfs/conf/masters PRE-CREATION 
  ec2/deploy.centos64/root/persistent-hdfs/conf/slaves PRE-CREATION 
  ec2/deploy.generic/root/mesos-ec2/ec2-variables.sh PRE-CREATION 
  ec2/deploy.lucid64/root/hadoop-0.20.2/conf/core-site.xml PRE-CREATION 
  ec2/deploy.lucid64/root/hadoop-0.20.2/conf/hadoop-env.sh PRE-CREATION 
  ec2/deploy.lucid64/root/hadoop-0.20.2/conf/hdfs-site.xml PRE-CREATION 
  ec2/deploy.lucid64/root/hadoop-0.20.2/conf/masters PRE-CREATION 
  ec2/deploy.lucid64/root/hadoop-0.20.2/conf/slaves PRE-CREATION 
  ec2/deploy.lucid64/root/mesos-ec2/cluster-url PRE-CREATION 
  ec2/deploy.lucid64/root/mesos-ec2/copy-dir PRE-CREATION 
  ec2/deploy.lucid64/root/mesos-ec2/hadoop-framework-conf/core-site.xml 
PRE-CREATION 
  ec2/deploy.lucid64/root/mesos-ec2/hadoop-framework-conf/hadoop-env.sh 
PRE-CREATION 
  ec2/deploy.lucid64/root/mesos-ec2/hadoop-framework-conf/mapred-site.xml 
PRE-CREATION 
  ec2/deploy.lucid64/root/mesos-ec2/haproxy+apache/haproxy.config.template 
PRE-CREATION 
  ec2/deploy.lucid64/root/mesos-ec2/masters PRE-CREATION 
  ec2/deploy.lucid64/root/mesos-ec2/mesos-daemon PRE-CREATION 
  ec2/deploy.lucid64/root/mesos-ec2/redeploy-mesos PRE-CREATION 
  ec2/deploy.lucid64/root/mesos-ec2/setup PRE-CREATION 
  ec2/deploy.lucid64/root/mesos-ec2/setup-slave PRE-CREATION 
  ec2/deploy.lucid64/root/mesos-ec2/setup-torque PRE-CREATION 
  ec2/deploy.lucid64/root/mesos-ec2/slaves PRE-CREATION 
  ec2/deploy.lucid64/root/mesos-ec2/ssh-no-keychecking PRE-CREATION 
  ec2/deploy.lucid64/root/mesos-ec2/start-mesos PRE-CREATION 
  ec2/deploy.lucid64/root/mesos-ec2/stop-mesos PRE-CREATION 
  ec2/deploy.lucid64/root/mesos-ec2/zoo PRE-CREATION 
  ec2/mesos-ec2 PRE-CREATION 
  ec2/mesos_ec2.py PRE-CREATION 
  frameworks/deploy_jar/README.txt PRE-CREATION 
  frameworks/deploy_jar/daemon_executor.py PRE-CREATION 
  frameworks/deploy_jar/daemon_executor.sh PRE-CREATION 
  frameworks/deploy_jar/daemon_framework PRE-CREATION 
  frameworks/deploy_jar/daemon_scheduler.py PRE-CREATION 
  frameworks/deploy_jar/haproxy.config.template PRE-CREATION 
  frameworks/deploy_jar/hw.jar PRE-CREATION 
  frameworks/haproxy+apache/README.txt PRE-CREATION 
  frameworks/haproxy+apache/haproxy+apache PRE-CREATION 
  frameworks/haproxy+apache/haproxy+apache.py PRE-CREATION 
  frameworks/haproxy+apache/haproxy.config.template PRE-CREATION 
  frameworks/haproxy+apache/startapache.py PRE-CREATION 
  frameworks/haproxy+apache/startapache.sh PRE-CREATION 
  frameworks/mesos-submit/executor PRE-CREATION 
  frameworks/mesos-submit/executor.py PRE-CREATION 
  frameworks/mesos-submit/mesos-submit PRE-CREATION 
  frameworks/mesos-submit/mesos_submit.py PRE-CREATION 
  frameworks/torque/README.txt PRE-CREATION 
  frameworks/torque/hpl-24node.qsub PRE-CREATION 
  frameworks/torque/hpl-48node.qsub PRE-CREATION 
  frameworks/torque/hpl-8node-small.qsub PRE-CREATION 
  frameworks/torque/hpl-8node.qsub PRE-CREATION 
  frameworks/torque/mesos-hpl/24node/HPL.dat PRE-CREATION 
  frameworks/torque/mesos-hpl/48node/HPL.dat PRE-CREATION 
  frameworks/torque/mesos-hpl/8node-small/HPL.dat PRE-CREATION 
  frameworks/torque/mesos-hpl/8node/HPL.dat PRE-CREATION 
  frameworks/torque/mesos-hpl/Make.Linux_PII_CBLAS PRE-CREATION 
  frameworks/torque/mesos-hpl/README PRE-CREATION 
  frameworks/torque/mpi_example.c PRE-CREATION 
  frameworks/torque/start_pbs_mom.py PRE-CREATION 
  frameworks/torque/start_pbs_mom.sh PRE-CREATION 
  frameworks/torque/test_date_sleep_date_1node.qsub PRE-CREATION 
  frameworks/torque/test_date_sleep_date_2node.qsub PRE-CREATION 
  frameworks/torque/test_date_sleep_date_3node.qsub PRE-CREATION 
  frameworks/torque/test_date_sleep_date_5node_10sec.qsub PRE-CREATION 
  frameworks/torque/test_date_sleep_date_5node_60sec.qsub PRE-CREATION 
  frameworks/torque/torquelib.py PRE-CREATION 
  frameworks/torque/torquesched.py PRE-CREATION 
  frameworks/torque/torquesched.sh PRE-CREATION 
  src/common/attributes.cpp aab114e1a5932e3f218b850e1afc7f2ef0f10e21 
  src/tests/attributes_tests.cpp 2e10eaf3c33e418603ea19090bb0bf9179af71f7 

Diff: https://reviews.apache.org/r/35986/diff/


Testing
-------

make check


Thanks,

haosdent huang

Reply via email to