> On July 10, 2015, 5:25 p.m., Ian Downes wrote: > > src/linux/perf.cpp, lines 469-474 > > <https://reviews.apache.org/r/36378/diff/1/?file=1004593#file1004593line469> > > > > We should document this behavior at os::release() and move this there > > as an alternative. > > > > If it's kept in here then make static? > > > > Argument should be named 'version', not 'v'. > > > > Does it need to have such a long function name, particularly if it's > > local? > > > > Version canonicalize(const Version& version).
MESOS-3029 raised to move function to stout, but the solution is not that obvious since we could (1) modify os::release to return the canonical version but then it would not match uname which would be an issue if you used it to try and find something like a kernel module or (2) provide a separate function which returns canonical release but then there is more potential for using the wrong one or (3) provide version with a custom sort order so that the returned string is as reported by uname but Version(3.0.0) sorts as less that Version(2.6.41). - Paul ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36378/#review91253 ----------------------------------------------------------- On July 10, 2015, 5:33 p.m., Paul Brett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36378/ > ----------------------------------------------------------- > > (Updated July 10, 2015, 5:33 p.m.) > > > Review request for mesos, Ben Mahler, Chi Zhang, Ian Downes, and Cong Wang. > > > Bugs: MESOS-2834 > https://issues.apache.org/jira/browse/MESOS-2834 > > > Repository: mesos > > > Description > ------- > > Refactor Linux Performance monitor to handle changing 'perf stat' output > versions depending on kernel version. > > > Diffs > ----- > > src/linux/perf.cpp 697b75e846a43d4f106ad8f39a18882836d7dc02 > > Diff: https://reviews.apache.org/r/36378/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Paul Brett > >
