> On June 26, 2015, 2:57 p.m., Jiang Yan Xu wrote:
> > include/mesos/mesos.proto, lines 1212-1214
> > <https://reviews.apache.org/r/34136/diff/2/?file=989752#file989752line1212>
> >
> >     Is it the intention that Image type is **defined** outside MesosInfo 
> > because DockerInfo can later reference it?
> >     
> >     Otherwise it feels more natual to define Image within MesosInfo.
> 
> Vinod Kone wrote:
>     +1 to put it inside MesosInfo.

I wanted it to be outside MesosInfo so it could be used by other container 
types, i.e., I don't see it as specific to MesosInfo, e.g., we could also 
support an AppcInfo which contained an Image::APPC.


- Ian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34136/#review89577
-----------------------------------------------------------


On June 22, 2015, 9:42 a.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34136/
> -----------------------------------------------------------
> 
> (Updated June 22, 2015, 9:42 a.m.)
> 
> 
> Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add ContainerImage protobuf.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 8df1211165169c9595e0e6e85b5ddc404345ff70 
> 
> Diff: https://reviews.apache.org/r/34136/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ian Downes
> 
>

Reply via email to