> On July 14, 2015, 9:03 p.m., Jiang Yan Xu wrote:
> > include/mesos/mesos.proto, lines 1211-1213
> > <https://reviews.apache.org/r/34136/diff/3/?file=1009139#file1009139line1211>
> >
> > So I found the use of the field `id` inconsistent in the code.
> >
> > Sometimes `id` has the `sha512-` prefix and sometimes not.
> >
> > I think we should consistently refer to `id` using the definition in
> > the
> > [spec](https://github.com/appc/spec/blob/806b17c86ba5e5d595fca3f7ed339c8a22fb46c3/spec/aci.md#image-id),
> > i.e., with the prefix.
> >
> > The fact that the ID is computed by the image creator using sha512 and
> > that the provisioner validates it using sha512 is merely an implementation
> > detail that is not a conern of higher level abstractions / APIs.
> >
> > So here I think in the comments we should not call it "Image hash" but
> > rather refer to the spec for its full definition. We can of course call out
> > the fact that it should have the "sha512-" perfix.
> >
> > What do you think?
>
> Timothy Chen wrote:
> Hi there,
> I'm going to commit this for Ian and just saw your comment.
> How about I reword the comment here to "// The ID of the Image. Please
> refer to the Appc spec for its definition."?
Actually I mis-read what you meant, how about:
// The ID of the Image.
// An image ID is canonically represented as a string prefixed by
// the algorithm used and the hash output (e.g. sha512-a83...).
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34136/#review91666
-----------------------------------------------------------
On July 12, 2015, 4:47 a.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34136/
> -----------------------------------------------------------
>
> (Updated July 12, 2015, 4:47 a.m.)
>
>
> Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add ContainerImage protobuf.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 1763129da535561503e89cbd8c4a371f8553d8d6
>
> Diff: https://reviews.apache.org/r/34136/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Downes
>
>
