----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36450/#review91506 -----------------------------------------------------------
LGTM. Will wait for the test before giving shipit. - Vinod Kone On July 13, 2015, 5:55 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36450/ > ----------------------------------------------------------- > > (Updated July 13, 2015, 5:55 p.m.) > > > Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-3012 > https://issues.apache.org/jira/browse/MESOS-3012 > > > Repository: mesos > > > Description > ------- > > To make the API more consistent, we'd like to have a single message that > expresses a network address. > > Also, this enables the message passing optimization in the scheduler driver > when receiving events, per MESOS-3012. > > > Diffs > ----- > > include/mesos/mesos.proto 1763129da535561503e89cbd8c4a371f8553d8d6 > src/master/master.cpp b877676afa6f3833eb7d2fb06beeaa288bd8bd5d > > Diff: https://reviews.apache.org/r/36450/diff/ > > > Testing > ------- > > Will add a follow up test. > > > Thanks, > > Ben Mahler > >
