> On July 15, 2015, 7:08 p.m., Vinod Kone wrote:
> > src/common/type_utils.cpp, line 131
> > <https://reviews.apache.org/r/36450/diff/2/?file=1011909#file1011909line131>
> >
> >     Is the order of query parameters important? Aren't these URLs 
> > equivalent?
> >     
> >     http://a.b.c/?k1=a&k2=b
> >     
> >     http://a.b.c/?k2=b&k1=a
> 
> Ben Mahler wrote:
>     Java's URI class considers ordering as important:
>     
>     
> http://grepcode.com/file/repository.grepcode.com/java/root/jdk/openjdk/6-b14/java/net/URI.java#URI.equals%28java.lang.Object%29
>     
>     I'd also like to keep it simple for now, you'll notice that they consider 
> percent encoding to be case-insensitive (e.g. %2C == %2c), but I'd hope we 
> can just avoid this for now:
>     
>     
> http://grepcode.com/file/repository.grepcode.com/java/root/jdk/openjdk/6-b14/java/net/URI.java#URI.equal%28java.lang.String%2Cjava.lang.String%29
>     
>     Ideally, we'd have a URI / URL class in stout, where we can have a 
> comprehensive equality operator.
> 
> Anand Mazumdar wrote:
>     +1 
>     
>     There is already a URL struct that exists in libprocess that we might 
> consider enriching upon later and also move it to stout.

I'll add a TODO related to this.


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36450/#review91795
-----------------------------------------------------------


On July 15, 2015, 1:01 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36450/
> -----------------------------------------------------------
> 
> (Updated July 15, 2015, 1:01 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-3012
>     https://issues.apache.org/jira/browse/MESOS-3012
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> To make the API more consistent, we'd like to have a single way to express a 
> network address.
> Also would like a way to express an HTTP address (a URL), which may include a 
> path prefix.
> 
> This also enables the message passing optimization in the scheduler driver 
> when receiving events, per MESOS-3012.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 1763129da535561503e89cbd8c4a371f8553d8d6 
>   include/mesos/type_utils.hpp e7bfe8ca60af945e76b5d85ab37cc97b17ff1b4a 
>   src/common/type_utils.cpp 19f79b47539ab51a5dff97f381a44c679cf5ecaf 
>   src/master/master.cpp b877676afa6f3833eb7d2fb06beeaa288bd8bd5d 
>   src/tests/master_tests.cpp 57721b788d0c70f4c6f5cc44d87465f52a70b6c2 
> 
> Diff: https://reviews.apache.org/r/36450/diff/
> 
> 
> Testing
> -------
> 
> Modified the simplest test I could find for offers.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Reply via email to