----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36106/#review91526 -----------------------------------------------------------
Ship it! Ship It! src/linux/cgroups.cpp (line 2022) <https://reviews.apache.org/r/36106/#comment144952> Extra space in the message. src/tests/cgroups_tests.cpp (line 1193) <https://reviews.apache.org/r/36106/#comment144950> We should use string instead of std::string here but I can fix that src/tests/cgroups_tests.cpp (line 1193) <https://reviews.apache.org/r/36106/#comment144951> We should use string instead of std::string here but I can fix that - Timothy Chen On July 10, 2015, 10:46 p.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36106/ > ----------------------------------------------------------- > > (Updated July 10, 2015, 10:46 p.m.) > > > Review request for mesos, Ian Downes, Jie Yu, Joris Van Remoortere, and > Timothy Chen. > > > Bugs: MESOS-2961 > https://issues.apache.org/jira/browse/MESOS-2961 > > > Repository: mesos > > > Description > ------- > > cgroups implementation does not have a cpuacct subsystem implementation as of > today. Adding the implementation for stat function. > > Changes: > - added Stats class to encapsulate cpuacct.stat data > - added implementation for cpuacct::stats > - added unit tests > > Jira: MESOS-2961 > > > Diffs > ----- > > src/linux/cgroups.hpp 73b98317880eea3d6a2ba37ac56d1f7e3600ba94 > src/linux/cgroups.cpp 4c006d0c7382b940a83359d636c0d48952cdbb00 > src/tests/cgroups_tests.cpp 475f48a474eea708f98d8c0300862351a2d4379a > > Diff: https://reviews.apache.org/r/36106/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jojy Varghese > >
