-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36106/
-----------------------------------------------------------
(Updated July 14, 2015, 12:38 a.m.)
Review request for mesos, Ian Downes, Jie Yu, Joris Van Remoortere, and Timothy
Chen.
Changes
-------
review comments @tim
Bugs: MESOS-2961
https://issues.apache.org/jira/browse/MESOS-2961
Repository: mesos
Description
-------
cgroups implementation does not have a cpuacct subsystem implementation as of
today. Adding the implementation for stat function.
Changes:
- added Stats class to encapsulate cpuacct.stat data
- added implementation for cpuacct::stats
- added unit tests
Jira: MESOS-2961
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/Makefile.am
856c2b289451fd404b97285b825e72913feb2f04
3rdparty/libprocess/3rdparty/stout/Makefile.am
89e7b1854bd7f449f4f0027d76c6430d259a24de
3rdparty/libprocess/3rdparty/stout/configure.ac
a1f86d0f943bbff91a8b021046eb66d624df7896
3rdparty/libprocess/3rdparty/stout/include/Makefile.am
2394b95462182273464f0847f416ad83c3b64485
3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp
81f6e50baca95ad7a3a0ac1434c8db1c4de6adf2
3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp
22d30eb80b4eca8be9cd4d48288f63fd52040ddd
3rdparty/libprocess/3rdparty/stout/tests/bits_tests.cpp
672820ab775648e459f34b0c0a20e4482cebfdac
3rdparty/libprocess/3rdparty/stout/tests/bytes_tests.cpp
5239805704cce8a545e11fcd83aa80484617f582
3rdparty/libprocess/3rdparty/stout/tests/cache_tests.cpp
6e42c7d56bd6ef47a968bee2a01ac47fb8a7ed26
3rdparty/libprocess/3rdparty/stout/tests/duration_tests.cpp
eccccf2f87781e7abcf1d25bc7a12cb6e18f695b
3rdparty/libprocess/3rdparty/stout/tests/error_tests.cpp
9e7605c53e6636e7fea32e4f69fbaff9100a979f
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp
ebf8cd656625b7fd414cacaa87f156c95df29438
3rdparty/libprocess/3rdparty/stout/tests/gzip_tests.cpp
01425d7205032280987021adcc97eb862a80c42c
3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp
984c02c982dc4dd8eb528d79e715847ef7a693b8
3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp
2826742187411e5be8da0517859ec0d558fc2921
3rdparty/libprocess/3rdparty/stout/tests/interval_tests.cpp
134ea2ee675aba13ddb7a28545b25b4f3701d5d9
3rdparty/libprocess/3rdparty/stout/tests/ip_tests.cpp
532d064dcc5e31d2824df750b7d3e6bddabddbb9
3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp
dd692094e164e33ba0f13e2b994c14cbfd827cbf
3rdparty/libprocess/3rdparty/stout/tests/linkedhashmap_tests.cpp
5e385f4e7c69dc252bdee2436c6a57f1a0f17d32
3rdparty/libprocess/3rdparty/stout/tests/mac_tests.cpp
0d398069ecd76002d5ee61765f0dd77f3b40bbb4
3rdparty/libprocess/3rdparty/stout/tests/main.cpp
1410cf18132fbaddea1498736ac539f77232de38
3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp
b625ffaeb3672f58fbd9558a868f87404e659c53
3rdparty/libprocess/3rdparty/stout/tests/none_tests.cpp
55e75207a8c5d2ac17cbee848855f4c66a2d2eb4
3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp
0c3f89bafe1afb15d1a2d775ed598cdf1a5ea147
3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp
e740d5bc0f0cc5cf8e99b2064c1e39c08282da67
3rdparty/libprocess/3rdparty/stout/tests/os/signals_tests.cpp
de86232cd4a646c63cdb41d18cd4375615cb42e4
3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp
2556bd428cc8990659e30e804b9c96c1659ef4a1
3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp
5d24f21f63433b8525370736dd630880d324ebeb
3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp
018ff51d10f4ba076609704d6e3b2c704c82b016
3rdparty/libprocess/3rdparty/stout/tests/set_tests.cpp
6f6b0babf896216815f447b2548b4a8036751d22
3rdparty/libprocess/3rdparty/stout/tests/some_tests.cpp
efb94ef3523e85d08498b5a3d5744d3eeee87ac5
3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp
ffe5f1bcf764f24cec1d191dcde289976b6281c4
3rdparty/libprocess/3rdparty/stout/tests/subcommand_tests.cpp
f0a69d49c7c97b2d437c751fbee0a9c0f0ada0a9
3rdparty/libprocess/3rdparty/stout/tests/thread_tests.cpp
319fcdf517b24f5bb9c85dad4093b09ec87e915e
3rdparty/libprocess/3rdparty/stout/tests/uuid_tests.cpp
b931151ed62d2a356c9c96188ae967089d92168c
3rdparty/libprocess/Makefile.am e9c42d7ecd44eebeadcc3d1d5011e01674b3415a
3rdparty/libprocess/configure.ac 7d1221bd5ddfc4fa816b0bbea0be5c6b20000cbb
3rdparty/libprocess/examples/example.cpp
22ae083d8b5bf59cf52e18405e005cfe94edb81d
3rdparty/libprocess/include/Makefile.am
3b6108dd37d23bd5104162e9e8f4a3aa0518cdcd
3rdparty/libprocess/include/process/address.hpp
be216db823160f5db1dfb4502bf832246fb3df6d
3rdparty/libprocess/include/process/async.hpp
d0c560aa48ef1c88407a6b1c42223fce3170245c
3rdparty/libprocess/include/process/clock.hpp
0f73f894c753711db4fdefa9df40d5674aacc6f7
3rdparty/libprocess/include/process/collect.hpp
a1e20515536c002290a4832d94e132a4d42056d8
3rdparty/libprocess/include/process/defer.hpp
c9caf58aab58c5ed8b5288a43405f88ba3b19c03
3rdparty/libprocess/include/process/deferred.hpp
b11acc4bed390fd33d782143afb6231fc7606bea
3rdparty/libprocess/include/process/delay.hpp
65e316e12b96f96058292faa4fc7a7f34c5c1c73
3rdparty/libprocess/include/process/dispatch.hpp
c5b8137586113016d702451260c18ff5cfa7c0a2
3rdparty/libprocess/include/process/event.hpp
522771a62bcdea458e33e4b15d590bd8c1dc5e22
3rdparty/libprocess/include/process/executor.hpp
434d23ac8119e24454f8bc8324d7b26ec62a85c7
3rdparty/libprocess/include/process/filter.hpp
db0dfc7ae89245b748337c53e524f3cb352ed301
3rdparty/libprocess/include/process/future.hpp
db92767619ec7b6ab1a0803c240725a2633d2489
3rdparty/libprocess/include/process/gc.hpp
72fde54ce2f727c89ca49485a0dfee124cb6fc2f
3rdparty/libprocess/include/process/gmock.hpp
e8781610f636954b39611fcb1de310a78ceea7cb
3rdparty/libprocess/include/process/gtest.hpp
2ae2a5a16e61304c969c4802990b31beb3964f25
3rdparty/libprocess/include/process/help.hpp
316ed21b5300496f283d0c331fa6d9dad441d332
3rdparty/libprocess/include/process/http.hpp
72b6d273d8ba4526bf237171690b8b0f81951f23
3rdparty/libprocess/include/process/id.hpp
a0bb5dbd93bc7e2f245e012032d54969eefd1d3e
3rdparty/libprocess/include/process/io.hpp
245716353ad5ffa8d705fc5e826addfa6a3594dc
3rdparty/libprocess/include/process/latch.hpp
460971e67a64c5b62bac5370a6a616c7f13bac51
3rdparty/libprocess/include/process/limiter.hpp
ce692883c74bc9a5cb4822567e5d7edee81ae0a3
3rdparty/libprocess/include/process/logging.hpp
03fb1bd51e105d0070760af6232dab03e85127d2
3rdparty/libprocess/include/process/message.hpp
e9c7e050a771ff88cbec49f5adb37c04138479be
3rdparty/libprocess/include/process/metrics/counter.hpp
6ea32200d1b26a192731d9c14bcda48cf7855917
3rdparty/libprocess/include/process/metrics/gauge.hpp
13934b8c48012a4ef38ba587deb1bce058425ccc
3rdparty/libprocess/include/process/metrics/metric.hpp
c5e61df09b06ff13695646eb97c69235a4fe8d56
3rdparty/libprocess/include/process/metrics/metrics.hpp
5a328d3786e047459d9b245c8dd38a00d3b41b3b
3rdparty/libprocess/include/process/metrics/timer.hpp
76890b7f8d6dfe8b27779f45c8172472071fdccf
3rdparty/libprocess/include/process/mime.hpp
decdfb6bc2eb60bfc6b25bc7227b11e8a11d5aff
3rdparty/libprocess/include/process/mutex.hpp
46e25df66325b029cb3e9bbc5e94d66aa5bac4e8
3rdparty/libprocess/include/process/network.hpp
4ae8b1153193a96a4719c482e5b31cc07fe5be3f
3rdparty/libprocess/include/process/once.hpp
7d0d9309a41a8cc7c074b7566b7b9c411fa8ad45
3rdparty/libprocess/include/process/owned.hpp
428e922327fd05e2e2f943bbb498cd58543cdc70
3rdparty/libprocess/include/process/pid.hpp
3bce0bc99e0ebe3ac06ba53155d558fb041cd76c
3rdparty/libprocess/include/process/process.hpp
8620547148f8a69d5b661eaf08063ca72347b6a4
3rdparty/libprocess/include/process/profiler.hpp
4082b8ae579aa11c688da961e126a94d8f121762
3rdparty/libprocess/include/process/protobuf.hpp
3ec3775165d1cef1d081e465d809d46e09d49b5c
3rdparty/libprocess/include/process/queue.hpp
7e3538763659dd3ca6c8cd61d17abb3af32bb01b
3rdparty/libprocess/include/process/reap.hpp
ca5acc4c8f5a62a49b7fde83946e283ea40baa65
3rdparty/libprocess/include/process/run.hpp
98de0fd30cc1dc5561c924a0e5e5fc18e24cf7a1
3rdparty/libprocess/include/process/sequence.hpp
2dec013012c01813d43f80899f1292eecc7e414d
3rdparty/libprocess/include/process/shared.hpp
b4d90ca0309be1116ae8421716894652b5bd0890
3rdparty/libprocess/include/process/socket.hpp
a882330b45be10bab1e3e8fd8983e172eb0e4efc
3rdparty/libprocess/include/process/statistics.hpp
2eafd3fba5350ab7bff65bc3a03abc7eb5025be9
3rdparty/libprocess/include/process/subprocess.hpp
310cb4f8e4e2faa5545dffd196d7490c868bc5d6
3rdparty/libprocess/include/process/system.hpp
7c8b49e78f76f9e131a4367f411c6dba447ccd90
3rdparty/libprocess/include/process/time.hpp
095409ac151c8ae3320c47cb50247718044dde83
3rdparty/libprocess/include/process/timeout.hpp
868da4935ca3c9959749b5c51b446179834086e4
3rdparty/libprocess/include/process/timer.hpp
02ebd32569cf0c25a1434107cd0cca76cf8a2659
3rdparty/libprocess/include/process/timeseries.hpp
becba435f022557b6b0b9df75fd2cd2c810c200d
3rdparty/libprocess/src/clock.cpp 09c60e5a5d9bd9fc5511e57f3209fad7dbf834d6
3rdparty/libprocess/src/config.hpp 721816432621c78b3ff5cc3176753821e9ef7975
3rdparty/libprocess/src/decoder.hpp fa2984ef267e7a381d024d20d1b37f1d39148559
3rdparty/libprocess/src/encoder.hpp c5ff7615c99e3e7eafb132182428c779324d72b8
3rdparty/libprocess/src/event_loop.hpp
45aa2a6019dc08da287b7c8a9d799619deb69747
3rdparty/libprocess/src/fatal.hpp 87a55dca4fe53c1f3fc7fb03914f3ec4270aa5b4
3rdparty/libprocess/src/fatal.cpp 76d5ee42be50651863f88189341d59cfd406bae4
3rdparty/libprocess/src/gate.hpp 7f6b3d8ddc823f637afcf6dc81b8371e4a794a0b
3rdparty/libprocess/src/http.cpp d1685799f4c53e067d0812e037e171324ee7195f
3rdparty/libprocess/src/io.cpp 4a6e18a17012994d358099ad32d4c282fea3b0b1
3rdparty/libprocess/src/latch.cpp f7d94d92e85c58878d98e13757b6fc37837ca977
3rdparty/libprocess/src/libev.hpp fd26728fe9c0688b82fd75f0bfc83b8d0a3b8581
3rdparty/libprocess/src/libev.cpp 8960c75010e3ceca3486a1fbb0fdeeffd62f4ec8
3rdparty/libprocess/src/libev_poll.cpp
ca391b50113baf2a678a6032b849bd5c8a0fd39f
3rdparty/libprocess/src/libevent.hpp 3a0a46ba95db95f4a007ec755012ac969d1c6cd9
3rdparty/libprocess/src/libevent.cpp 02f9e61c1357e7b450e53b252b49d1979e782ae8
3rdparty/libprocess/src/libevent_poll.cpp
ff689865d7352249a6747bbe4fc7d8e3e2a73fe7
3rdparty/libprocess/src/libevent_ssl_socket.hpp
3b17fa278a92461cf74179084a717909224c3d9c
3rdparty/libprocess/src/libevent_ssl_socket.cpp
80db6e83f14de5fd241565009d8a60aa964e790c
3rdparty/libprocess/src/logging.cpp 3d855e90e83a54cd344e49f075af0eadef1a1358
3rdparty/libprocess/src/metrics/metrics.cpp
b9617507a16318b7de25d4875d6bc0b4409fcd29
3rdparty/libprocess/src/openssl.hpp 3f8d351589f8bb26c886da12c53b5e02a242376a
3rdparty/libprocess/src/openssl.cpp 6aa2a4db8d64011d0fde6ff0cf4b144c41949d39
3rdparty/libprocess/src/openssl_util.hpp
0890b63f5df58b7cae7bc788e2f1eba6b03c7757
3rdparty/libprocess/src/openssl_util.cpp
42b2860beccff929563ed05905da226b781918b7
3rdparty/libprocess/src/pid.cpp a5c527443cebb0c150f59fb4abe80216794a209b
3rdparty/libprocess/src/poll_socket.hpp
79531cb3f486cedef2ab0e91402342fb4b839bff
3rdparty/libprocess/src/poll_socket.cpp
4da62b698ac9c5bbd4f1eee6188b6dcca03aa099
3rdparty/libprocess/src/process.cpp d6b0d5517964bf7c7276689e801a38b34a3f9db2
3rdparty/libprocess/src/process_reference.hpp
c070158defe234bfcdff06a829c7a001dc66ba1f
3rdparty/libprocess/src/profiler.cpp 65a2e05e8f6005a378ae3647698dcba60fb95e9f
3rdparty/libprocess/src/reap.cpp 9a994b052c7920a16557c3d880ad499a5efd43cb
3rdparty/libprocess/src/socket.cpp 5879423bd92c5805353a962cbd822a993b0568c5
3rdparty/libprocess/src/subprocess.cpp
d6ea62ed1c914d34e0e189395831c86fff8aac22
3rdparty/libprocess/src/test-master.cpp
2a2ed0e9ac58d7973b1254c708cbd97a7a33b762
3rdparty/libprocess/src/test-slave.cpp
5a924a0bca21397f059cf558d67853cc4103e5da
3rdparty/libprocess/src/tests/decoder_tests.cpp
6994fa96d33209f9a367b8c3bb09b0d050023fad
3rdparty/libprocess/src/tests/encoder_tests.cpp
0032137858cfeba061c68cc5f026bb4a659b8350
3rdparty/libprocess/src/tests/http_tests.cpp
01f243cd9c46e162c16e9bb452a846faf31d1445
3rdparty/libprocess/src/tests/io_tests.cpp
c642b3333ab9e2845668767ad237985cb9ce1109
3rdparty/libprocess/src/tests/limiter_tests.cpp
ba722509fefc3cd592b6f41d02a0b12d5adf7e00
3rdparty/libprocess/src/tests/main.cpp
eec0c5f085dfed6dfeb3941528043dbd2eadcb59
3rdparty/libprocess/src/tests/metrics_tests.cpp
29ed0330a498579896bbef3349572dd35299a40a
3rdparty/libprocess/src/tests/mutex_tests.cpp
484727fd36c04f8a3380808d0f75eaad11338331
3rdparty/libprocess/src/tests/owned_tests.cpp
3ef76b8d5426ea10f63bf78b96f45046dd8a955a
3rdparty/libprocess/src/tests/process_tests.cpp
bc54d29235e7cf015d796f83000a136788c7df65
3rdparty/libprocess/src/tests/queue_tests.cpp
a6a0dab42ea1674256e8990255bf507aa24f24b8
3rdparty/libprocess/src/tests/reap_tests.cpp
642ab97b28a6085dc9837f14ff36a3124387a03b
3rdparty/libprocess/src/tests/sequence_tests.cpp
88de001aad259c3035f2ff20ed61e7e119a73f54
3rdparty/libprocess/src/tests/shared_tests.cpp
74ea26060ac2800cb98dffbfc90494871d0a9e21
3rdparty/libprocess/src/tests/ssl_client.cpp
9ae59e54bab954b1a931dbc3bd2f1540deb9f5aa
3rdparty/libprocess/src/tests/ssl_tests.cpp
2fe50601615b0bee57bd3e05dc9c932f93ca7477
3rdparty/libprocess/src/tests/statistics_tests.cpp
657d27aed18949fa8200236662f2897bdddd2ef4
3rdparty/libprocess/src/tests/subprocess_tests.cpp
f6acb204582a9e696c3b09d4e4c543bb052e97d4
3rdparty/libprocess/src/tests/time_tests.cpp
60791ff20671859a0da91524ae8e40ff52c907d0
3rdparty/libprocess/src/tests/timeseries_tests.cpp
ec6f4868a65b89244fb4bb8234a77c87831863c3
3rdparty/libprocess/src/time.cpp 87f1f367f422df0efe3bd57f983404e572dc5314
3rdparty/libprocess/src/timeseries.cpp
f5bd65a50a822fd6a774d9d2e458906b7029082c
CHANGELOG 4004da595e516c04a80468ce202aef462cbe1382
docs/app-framework-development-guide.md
17cfec21a0b68c6e211ee7b75486ca048b24d963
docs/configuration.md feee5594c88112f77ce382cb3dd8628653f92d01
docs/home.md a02fea62360b39ed6af2025db52c06014f0a4ef2
docs/logging-and-debugging.md 6797d156b244e0f08dbd754c5adc80a22e247693
docs/mesos-doxygen-style-guide.md 1bd3b3d373af4ab39df1ab8b1ed9c78dc3bfc721
docs/network-monitoring.md acd70c5643a55e6825ad61e42ca4ced5f7f0482e
src/cli/mesos.cpp 80c3c1a7e30e7e148e17c379ec6824ab7e4c0f12
src/common/protobuf_utils.cpp 9ac81c38efd70f92c64a5865fa79fe516e84dd92
src/files/files.cpp a94a5eec0d4cf095f84255a66117947a308fdb2f
src/hdfs/hdfs.hpp a070c3200f0a0ac48ec86451749c7faf10c7f6a7
src/linux/cgroups.hpp 73b98317880eea3d6a2ba37ac56d1f7e3600ba94
src/linux/cgroups.cpp 4c006d0c7382b940a83359d636c0d48952cdbb00
src/logging/flags.cpp c77f845a492728168df2f20f040835c5df35b87a
src/master/master.cpp b877676afa6f3833eb7d2fb06beeaa288bd8bd5d
src/sched/sched.cpp e372a15db035f74d525561839b873ed659e2c33f
src/scheduler/scheduler.cpp ac2358594de3861a1dddcdf82c2cba670c6f7181
src/slave/containerizer/containerizer.hpp
52145540ff250890885a2d3f247fedcb8498b58b
src/slave/containerizer/containerizer.cpp
25c87e9f948b7efe8b9a853c403bee69982d6c4c
src/slave/containerizer/docker.hpp 9a7a951a72390b38f5dda3a3d50c4b35a6c784fd
src/slave/containerizer/docker.cpp cfb60177fe48ec0eeab12ff392c6c9f89634b92f
src/slave/state.cpp f8a9514f52bf9f886171c2a0e674e5a89f8dbea7
src/state/in_memory.hpp 6fdebdbdb94a9f8bfcfe3748a3fb0565ff255028
src/state/in_memory.cpp 4977fcf0ec92bf1f03ec7868efb6c4a7c79fc9f5
src/state/leveldb.hpp 135b88fd13b4d8a4e87b974d916cf7503fd2629d
src/state/leveldb.cpp 470db42dd8ef276530ecddba49beebaccaeb2e96
src/state/log.hpp 3795a3aec6e8ecaab74221346fc1782870245d5a
src/state/log.cpp 7b58b93c0d93a1f616cb9f2af25eedb94c8c8f23
src/state/zookeeper.hpp 408af4180cd36b3efd6499a6ec3acba001d70060
src/state/zookeeper.cpp 54ee88cfda3b711df7bc0f927320bfc68724fe64
src/tests/active_user_test_helper.cpp
39e7378a3b3c8936dd0a70514b9a05a14a880b90
src/tests/cgroups_tests.cpp 475f48a474eea708f98d8c0300862351a2d4379a
src/zookeeper/authentication.hpp 1c503077cd577cd0440e62d7b9c7ddf128bbceab
src/zookeeper/authentication.cpp 03e6eea295e8a0ff217e6902106b3cd66362dfcf
src/zookeeper/contender.hpp fc05613a8983f3a3efc24713bbefee895149da4b
src/zookeeper/contender.cpp 2050464a32fe651ab469529bbc90819ee9822746
src/zookeeper/detector.hpp 5b39ed58b9b3a162faa039179f429d779a782d6d
src/zookeeper/detector.cpp 244f188da52114524504679e1f817d56378436cb
src/zookeeper/group.hpp 9e0ed327aec6f26982984d8fd379dbd6140589b3
src/zookeeper/group.cpp 401008513c2233b16518bbc875ed86d519c42168
src/zookeeper/watcher.hpp 487734316e1f626bac0543d453646555ea51b4b9
support/post-reviews.py 78201ee79dc528a0cfdd0b89cc0a191be3d5846c
Diff: https://reviews.apache.org/r/36106/diff/
Testing
-------
make check
Thanks,
Jojy Varghese
