----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36547/#review91885 -----------------------------------------------------------
src/launcher/fetcher.cpp (line 123) <https://reviews.apache.org/r/36547/#comment145590> s\response\status (to be consistent with below) src/launcher/fetcher.cpp (line 125) <https://reviews.apache.org/r/36547/#comment145589> s\successCode\successStatusCode src/launcher/fetcher.cpp (line 128) <https://reviews.apache.org/r/36547/#comment145588> indentation +2 spaces (https://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Conditionals) - Joerg Schad On July 16, 2015, 2:25 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36547/ > ----------------------------------------------------------- > > (Updated July 16, 2015, 2:25 p.m.) > > > Review request for mesos, Bernd Mathiske and Joerg Schad. > > > Bugs: MESOS-3060 > https://issues.apache.org/jira/browse/MESOS-3060 > > > Repository: mesos > > > Description > ------- > > The response code for successful FTP file transfers is 226, while it is 200 > for HTTP. The fetcher has been changed to check for a response code of 226 > for FTP URIs. > > > Diffs > ----- > > src/launcher/fetcher.cpp 8aee4901ec1289f43b5fa6b830c3488815ec24cd > > Diff: https://reviews.apache.org/r/36547/diff/ > > > Testing > ------- > > make check & external FTP server test. > > > Thanks, > > Jan Schlicht > >
