> On July 16, 2015, 7:41 p.m., Joerg Schad wrote:
> > src/launcher/fetcher.cpp, line 134
> > <https://reviews.apache.org/r/36547/diff/3/?file=1013405#file1013405line134>
> >
> >     I assume those are spaces? Could you please doublecheck?

These are spaces. It's probably like this to indicate that the spacing changed.


> On July 16, 2015, 7:41 p.m., Joerg Schad wrote:
> > src/launcher/fetcher.cpp, line 136
> > <https://reviews.apache.org/r/36547/diff/3/?file=1013405#file1013405line136>
> >
> >     can you add a short comment why we assume this here?

Added a check to narrow the supported URI protocols.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36547/#review91913
-----------------------------------------------------------


On July 16, 2015, 6:55 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36547/
> -----------------------------------------------------------
> 
> (Updated July 16, 2015, 6:55 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Joerg Schad.
> 
> 
> Bugs: MESOS-3060
>     https://issues.apache.org/jira/browse/MESOS-3060
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The response code for successful FTP file transfers is 226, while it is 200 
> for HTTP. The fetcher has been changed to check for a response code of 226 
> for FTP URIs.
> 
> 
> Diffs
> -----
> 
>   src/launcher/fetcher.cpp 8aee4901ec1289f43b5fa6b830c3488815ec24cd 
> 
> Diff: https://reviews.apache.org/r/36547/diff/
> 
> 
> Testing
> -------
> 
> make check & external FTP server test.
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Reply via email to