-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32750/#review92576
-----------------------------------------------------------


I had this reviewed by yet another front end expert (Philip Norman) and he 
confirms that the CSS selector is not ideal and breaks the responsive flow. 
Furthermore, if the sidebar remains within the grid it should not have any 
fixed width applied to it. The correct fix probably removes the grid 
completely. 

Are you going to pick up work on this again, with a different approach?

- Bernd Mathiske


On April 2, 2015, 3:26 p.m., Alson Kemp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32750/
> -----------------------------------------------------------
> 
> (Updated April 2, 2015, 3:26 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-2585
>     https://issues.apache.org/jira/browse/MESOS-2585
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> MESOS-2585: Use full width for mesos div.container
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/css/mesos.css 
> 5b1227e9d64757f9fc106e497f7fa3ed72112c10 
>   src/webui/master/static/index.html 25caf530628ad3ac7f23ab5f014000aac8583da1 
> 
> Diff: https://reviews.apache.org/r/32750/diff/
> 
> 
> Testing
> -------
> 
> Visual verification.
> 
> 
> Thanks,
> 
> Alson Kemp
> 
>

Reply via email to