-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36024/#review93089
-----------------------------------------------------------


After discussing this with the shepherd it was decided to drop this patch. The 
benefits of refactoring the copy-pasted boilerplate code are overshadowed by 
reduced readability and added complexity.

- Artem Harutyunyan


On July 9, 2015, 10:20 p.m., Artem Harutyunyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36024/
> -----------------------------------------------------------
> 
> (Updated July 9, 2015, 10:20 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-2862
>     https://issues.apache.org/jira/browse/MESOS-2862
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Refactored OSNetUri tests for fetcher to avoid code copy/pasting.
> 
> 
> Diffs
> -----
> 
>   src/tests/fetcher_tests.cpp ae10c420f7dddb8650377c91b5343591e8560392 
> 
> Diff: https://reviews.apache.org/r/36024/diff/
> 
> 
> Testing
> -------
> 
> # This is a test case refactoring.
> 
> $ make check
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Reply via email to