-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36842/#review93099
-----------------------------------------------------------


Patch looks great!

Reviews applied: [36822, 36823, 36824, 36825, 36826, 36827, 36828, 36829, 
36830, 36842]

All tests passed.

- Mesos ReviewBot


On July 27, 2015, 7:19 a.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36842/
> -----------------------------------------------------------
> 
> (Updated July 27, 2015, 7:19 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joseph Wu, and 
> Michael Park.
> 
> 
> Bugs: MESOS-3122
>     https://issues.apache.org/jira/browse/MESOS-3122
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> use --enable-static-unimplemented to get compile time errors as opposed
> to runtime errors.
> 
> 
> Diffs
> -----
> 
>   configure.ac 546c9bbf775a4ef481fafb3a58c85c6d80e19500 
> 
> Diff: https://reviews.apache.org/r/36842/diff/
> 
> 
> Testing
> -------
> 
> created a function with an `UNIMPLEMENTED()` body and verified the runtime 
> error occured when configured by default, and a compile-time error ocurred 
> when configured with `--enable-static-unimplemented`
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Reply via email to