> On Aug. 1, 2015, 12:22 a.m., Ben Mahler wrote: > > configure.ac, lines 1560-1561 > > <https://reviews.apache.org/r/36842/diff/2/?file=1026427#file1026427line1560> > > > > Hm.. coming across this I can't tell how this works, mind adding a > > comment? > > > > The following seems like magic: > > > > ``` > > inline Try<Nothing> cloexec(int fd) > > { > > UNIMPLEMENTED; // what is this symbol? can't find it > > } > > ```
Ah, sorry I was looking at UNIMPLEMENTED in some of the committed os.hpp code before unimplemented.hpp was committed, I guess the commit order was wrong? Anyway, perhaps having a pointer to stout's unimplemented.hpp would be nice in the configure.ac code. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36842/#review93823 ----------------------------------------------------------- On July 31, 2015, 9:54 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36842/ > ----------------------------------------------------------- > > (Updated July 31, 2015, 9:54 p.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joseph Wu, and > Michael Park. > > > Bugs: MESOS-3122 > https://issues.apache.org/jira/browse/MESOS-3122 > > > Repository: mesos > > > Description > ------- > > use --enable-static-unimplemented to get compile time errors as opposed > to runtime errors. > > > Diffs > ----- > > configure.ac 546c9bbf775a4ef481fafb3a58c85c6d80e19500 > > Diff: https://reviews.apache.org/r/36842/diff/ > > > Testing > ------- > > created a function with an `UNIMPLEMENTED()` body and verified the runtime > error occured when configured by default, and a compile-time error ocurred > when configured with `--enable-static-unimplemented` > > > Thanks, > > Joris Van Remoortere > >
