-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36827/#review93166
-----------------------------------------------------------



3rdparty/libprocess/src/libevent.cpp (line 192)
<https://reviews.apache.org/r/36827/#comment147434>

    Does it have to be defined to == 1 or can it just be defined? E.g.,
    
    #elif defined(EVTHREAD_USE_WINDOWS_THREADS_IMPLEMENTED)



3rdparty/libprocess/src/libevent.cpp (lines 197 - 199)
<https://reviews.apache.org/r/36827/#comment147433>

    Why not just:
    
    #error "Libevent must be compiled with either ..."
    
    For the cases you know are compile time errors and don't have any 
expression that needs to get evaluated? Also, any reason you didn't go with 
'static_assert(false, ...)' too?



3rdparty/libprocess/src/openssl.cpp (line 172)
<https://reviews.apache.org/r/36827/#comment147435>

    Seems like a great use of 'static_assert'!



3rdparty/libprocess/src/openssl.cpp (line 174)
<https://reviews.apache.org/r/36827/#comment147437>

    s/use as the id_function/used as a function for determining a thread id/


- Benjamin Hindman


On July 27, 2015, 7:01 a.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36827/
> -----------------------------------------------------------
> 
> (Updated July 27, 2015, 7:01 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael 
> Park.
> 
> 
> Bugs: MESOS-3119
>     https://issues.apache.org/jira/browse/MESOS-3119
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/libevent.cpp 
> 1f175a4ae83391152d064779c6ab69d31cbaf867 
>   3rdparty/libprocess/src/openssl.cpp 
> 6aa2a4db8d64011d0fde6ff0cf4b144c41949d39 
> 
> Diff: https://reviews.apache.org/r/36827/diff/
> 
> 
> Testing
> -------
> 
> make check.
> Waiting on validation from someone with an OSX build
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Reply via email to