> On July 27, 2015, 7:19 p.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/src/libevent.cpp, lines 197-199 > > <https://reviews.apache.org/r/36827/diff/2/?file=1022224#file1022224line197> > > > > Why not just: > > > > #error "Libevent must be compiled with either ..." > > > > For the cases you know are compile time errors and don't have any > > expression that needs to get evaluated? Also, any reason you didn't go with > > 'static_assert(false, ...)' too?
Because I just learned about a new preprocessor directive! ;-) I didn't use static_assert(false, ...) because it always evaluates as an assertion failure even if a template specialization is not used. In this case it would have worked because it's controlled by conditional compilation, but I just stay away from it :-) - Joris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36827/#review93166 ----------------------------------------------------------- On July 27, 2015, 7:01 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36827/ > ----------------------------------------------------------- > > (Updated July 27, 2015, 7:01 a.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael > Park. > > > Bugs: MESOS-3119 > https://issues.apache.org/jira/browse/MESOS-3119 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/src/libevent.cpp > 1f175a4ae83391152d064779c6ab69d31cbaf867 > 3rdparty/libprocess/src/openssl.cpp > 6aa2a4db8d64011d0fde6ff0cf4b144c41949d39 > > Diff: https://reviews.apache.org/r/36827/diff/ > > > Testing > ------- > > make check. > Waiting on validation from someone with an OSX build > > > Thanks, > > Joris Van Remoortere > >
