-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36867/#review93242
-----------------------------------------------------------


Great first patch. Thanks for updating FrameworkInfo on reregistration with the 
master too!
A handful of nits in my first pass. I'll take another look once you've 
simplified the tests with Kapil's suggestions.


src/master/http.cpp (line 234)
<https://reviews.apache.org/r/36867/#comment147575>

    You shouldn't need the `mesos::` since you're nested inside 
`mesos::internal::master`.
    
    Nit: We don't usually use `const` for temporaries like this. Mostly for 
parameters, string constants, and other `const&`'s, like iterators.



src/master/master.hpp (line 1361)
<https://reviews.apache.org/r/36867/#comment147582>

    Nit: We actually limit comments to a 70 char limit.
    See http://mesos.apache.org/documentation/latest/mesos-c++-style-guide/



src/tests/master_tests.cpp (line 3551)
<https://reviews.apache.org/r/36867/#comment147585>

    Nit: Double blank lines between top-level functions/classes, please.



src/tests/master_tests.cpp (line 3559)
<https://reviews.apache.org/r/36867/#comment147586>

    Unused. Remove.



src/tests/master_tests.cpp (line 3595)
<https://reviews.apache.org/r/36867/#comment147588>

    Nit: Only indent 2 spaces after wrapping on `=`.


- Adam B


On July 27, 2015, 6:25 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36867/
> -----------------------------------------------------------
> 
> (Updated July 27, 2015, 6:25 p.m.)
> 
> 
> Review request for mesos, Adam B, Connor Doyle, and Niklas Nielsen.
> 
> 
> Bugs: MESOS-2841
>     https://issues.apache.org/jira/browse/MESOS-2841
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is intended to support frameworks that want to offer capabilities to the
> rest of the cluster (e.g., storage or some arbitrary third-party service). We
> want processes running in the cluster to be able to discover these 
> capabilities;
> however, we don't want to commit to a fixed set of capabilities or how those
> capabilities should be represented. Hence, this commit represents this
> information using freeform key-value pairs, similar to the labels mechanism
> already in use elsewhere.
> 
> Jira: MESOS-2841
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto a6748d1cd82238f005c6a49c70d22d095462f1ba 
>   src/master/http.cpp 3a1598fad4db03e5f62fd4a6bd26b2bedeee4070 
>   src/master/master.hpp 2c924addfb4c52d3048ee6ded13ce638145cc93f 
>   src/tests/fault_tolerance_tests.cpp 
> 7b977f5e8195d9f42b21f36eb36fb156471caa20 
>   src/tests/master_tests.cpp 05c148ee1660b86428afe4eda718b17052743a8c 
> 
> Diff: https://reviews.apache.org/r/36867/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Reply via email to