Thanks for the great feedback! I addressed almost all of these issues, but
had a few things left to wrap up before uploading a new patch -- I'm
traveling at the moment, but I should have a new patch by tomorrow.
On Mon, Aug 3, 2015 at 8:45 PM Adam B <a...@mesosphere.io> wrote:
> This is an automatically generated e-mail. To reply, visit:
> On July 27th, 2015, 11:36 p.m. PDT, *Adam B* wrote:
> Great first patch. Thanks for updating FrameworkInfo on reregistration with
> the master too!
> A handful of nits in my first pass. I'll take another look once you've
> simplified the tests with Kapil's suggestions.
> On August 3rd, 2015, 1:33 p.m. PDT, *Niklas Nielsen* wrote:
> Any updates here? :)
> Looks like @neilc or somebody resolved some of these issues, but I don't see
> a new patch revision with the changes. Neil?
> - Adam
> On July 27th, 2015, 6:25 p.m. PDT, Neil Conway wrote:
> Review request for mesos, Adam B, Connor Doyle, and Niklas Nielsen.
> By Neil Conway.
> *Updated July 27, 2015, 6:25 p.m.*
> *Bugs: * MESOS-2841 <https://issues.apache.org/jira/browse/MESOS-2841>
> *Repository: * mesos
> This is intended to support frameworks that want to offer capabilities to the
> rest of the cluster (e.g., storage or some arbitrary third-party service). We
> want processes running in the cluster to be able to discover these
> however, we don't want to commit to a fixed set of capabilities or how those
> capabilities should be represented. Hence, this commit represents this
> information using freeform key-value pairs, similar to the labels mechanism
> already in use elsewhere.
> Jira: MESOS-2841
> make check
> - include/mesos/mesos.proto (a6748d1cd82238f005c6a49c70d22d095462f1ba)
> - src/master/http.cpp (3a1598fad4db03e5f62fd4a6bd26b2bedeee4070)
> - src/master/master.hpp (2c924addfb4c52d3048ee6ded13ce638145cc93f)
> - src/tests/fault_tolerance_tests.cpp
> - src/tests/master_tests.cpp (05c148ee1660b86428afe4eda718b17052743a8c)
> View Diff <https://reviews.apache.org/r/36867/diff/>