> On July 29, 2015, 3:12 a.m., Anand Mazumdar wrote: > > src/tests/master_tests.cpp, line 2145 > > <https://reviews.apache.org/r/36807/diff/1/?file=1021582#file1021582line2145> > > > > Can just use auto here ? It's quite self-explanatory. > > > > auto master = master_.get();
why not indeed. > On July 29, 2015, 3:12 a.m., Anand Mazumdar wrote: > > src/tests/master_tests.cpp, line 2167 > > <https://reviews.apache.org/r/36807/diff/1/?file=1021582#file1021582line2167> > > > > Nit: > > > > s/Protect from flaky failures on those hosts/Protect from failures on > > hosts LoL - did I just invent a new oxymoron? Thanks for catching it! (on second thought, it'd be more of a tautology... or a children's book character: Mr. Fox Flaky Failures :) - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36807/#review93385 ----------------------------------------------------------- On July 29, 2015, 1:01 a.m., Marco Massenzio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36807/ > ----------------------------------------------------------- > > (Updated July 29, 2015, 1:01 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-2736 > https://issues.apache.org/jira/browse/MESOS-2736 > > > Repository: mesos > > > Description > ------- > > We want to test that when the master gets initialized, the > MasterInfo that it creates (and gets ultimately serialized to > ZooKeeper) has the correct information in its Address field. > > Currently, the test hangs when run in after another > MasterZooKeeperTest, due to some issues around the recovery. > > Jira: MESOS-2736 > > > Diffs > ----- > > src/tests/master_tests.cpp 05c148ee1660b86428afe4eda718b17052743a8c > > Diff: https://reviews.apache.org/r/36807/diff/ > > > Testing > ------- > > make check > (after @vinodkone fix all tests pass) > > > Thanks, > > Marco Massenzio > >
