-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36847/#review93923
-----------------------------------------------------------



3rdparty/libprocess/include/process/http.hpp (line 736)
<https://reviews.apache.org/r/36847/#comment148360>

    please don't use abbreviations.
    `delete()` is the HTTP method name.
    
    I'm almost sure it violates our style guide (and I'm positive it violates 
Google's).



3rdparty/libprocess/include/process/http.hpp (line 741)
<https://reviews.apache.org/r/36847/#comment148361>

    I would so much love to see the javadoc used, so this shows up in the 
online documentation (and in my IDE when I hover over the callsite); instead of 
having to go fisthing for the source file and find this documentation....



3rdparty/libprocess/src/http.cpp (lines 927 - 929)
<https://reviews.apache.org/r/36847/#comment148363>

    I would add a statement in the (javadoc?) method's documentation, to the 
effect that a query or fragment parts should *not* be used in this request, and 
the outcome of doing so are undefined.
    
    This would also follow the principle of "least surprise" for the callers of 
this method (who would also not need to go reverse engineering the code to 
figure out why their code ain't working...)


- Marco Massenzio


On July 29, 2015, 1:39 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36847/
> -----------------------------------------------------------
> 
> (Updated July 29, 2015, 1:39 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Bernd Mathiske.
> 
> 
> Bugs: MESOS-3152
>     https://issues.apache.org/jira/browse/MESOS-3152
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp 
> 9faed55247a3ccd629db7b85dbf31d3117e120e9 
>   3rdparty/libprocess/src/http.cpp d1685799f4c53e067d0812e037e171324ee7195f 
>   3rdparty/libprocess/src/tests/http_tests.cpp 
> 01f243cd9c46e162c16e9bb452a846faf31d1445 
> 
> Diff: https://reviews.apache.org/r/36847/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Reply via email to