> On Aug. 3, 2015, 5:47 p.m., Marco Massenzio wrote: > > 3rdparty/libprocess/src/http.cpp, lines 927-929 > > <https://reviews.apache.org/r/36847/diff/4/?file=1023561#file1023561line927> > > > > I would add a statement in the (javadoc?) method's documentation, to > > the effect that a query or fragment parts should *not* be used in this > > request, and the outcome of doing so are undefined. > > > > This would also follow the principle of "least surprise" for the > > callers of this method (who would also not need to go reverse engineering > > the code to figure out why their code ain't working...)
I created MESOS-3163 to also handle/discuss this across the other methods. is that ok for you? - Joerg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/#review93923 ----------------------------------------------------------- On July 29, 2015, 1:39 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36847/ > ----------------------------------------------------------- > > (Updated July 29, 2015, 1:39 p.m.) > > > Review request for mesos, Alexander Rukletsov and Bernd Mathiske. > > > Bugs: MESOS-3152 > https://issues.apache.org/jira/browse/MESOS-3152 > > > Repository: mesos > > > Description > ------- > > see summary. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/http.hpp > 9faed55247a3ccd629db7b85dbf31d3117e120e9 > 3rdparty/libprocess/src/http.cpp d1685799f4c53e067d0812e037e171324ee7195f > 3rdparty/libprocess/src/tests/http_tests.cpp > 01f243cd9c46e162c16e9bb452a846faf31d1445 > > Diff: https://reviews.apache.org/r/36847/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joerg Schad > >
