-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35874/#review94347
-----------------------------------------------------------

Ship it!


I'll get this committed for you with the minor changes below.


3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp (lines 62 - 66)
<https://reviews.apache.org/r/35874/#comment148917>

    Let's omit the "Apparently a bug in the ..." part of the comment.
    ```
    // An implementation based on the move constructor of 'hashmap'
    // fails to compile on all major compilers except gcc 5.1 and up.
    // See http://stackoverflow.com/q/31051466/118750?sem=2.
    ```



3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp (lines 67 - 71)
<https://reviews.apache.org/r/35874/#comment148921>

    Let's keep this consistent with the patterns in the other constructors.
    ```
    boost::unordered_set<Elem, Hash, Equal>::reserve(set.size());
    
    for (auto iterator = set.begin(); iterator != set.end(); ++iterator) {
      boost::unordered_set<Elem, Hash, Equal>::emplace(std::move(*iterator));
    }
    ```



3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp (lines 120 - 121)
<https://reviews.apache.org/r/35874/#comment148919>

    2 indents after assignment operator.


- Michael Park


On July 7, 2015, 8:51 a.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35874/
> -----------------------------------------------------------
> 
> (Updated July 7, 2015, 8:51 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Michael Park, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-2924
>     https://issues.apache.org/jira/browse/MESOS-2924
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds extra template parameters to hashset as well as implicit constructors 
> from
> `std::set` and a initializer list constructor.
> 
> These changes keep hashset up to date with the changes in hashmap.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp 
> 75ed9db54dc9ab502e978f06c55a621cacb56b91 
>   3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp 
> 3c4b732432c0c155451d34ecd5f985318d118fe5 
> 
> Diff: https://reviews.apache.org/r/35874/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Reply via email to