----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37065/#review94376 -----------------------------------------------------------
Ship it! Thanks for the exploration, just a few comments on comments. src/tests/containerizer/memory_test_helper.cpp (line 76) <https://reviews.apache.org/r/37065/#comment148954> This doesn't sound accurate to me: `to make sure allocated memory is mapped`. I think maybe something like `to make sure the mapped memory is locked` would be more accurate? src/tests/containerizer/memory_test_helper.cpp (lines 80 - 82) <https://reviews.apache.org/r/37065/#comment148953> `mlockall` is not what we want ideally right? Can we mention that it's not ideal but that it exists temporarily to address `MESOS-3197`? src/tests/containerizer/memory_test_helper.cpp (lines 97 - 98) <https://reviews.apache.org/r/37065/#comment148952> Could we add some additional comment here to describe why we need to do this? Something like: ``` Since `mlockall` is left unimplemented in OS X, we need to use `mlock` instead. ``` - Michael Park On Aug. 6, 2015, 5:54 a.m., Artem Harutyunyan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37065/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2015, 5:54 a.m.) > > > Review request for mesos, Benjamin Hindman and Michael Park. > > > Bugs: MESOS-3197 > https://issues.apache.org/jira/browse/MESOS-3197 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/containerizer/memory_test_helper.cpp > 5e40b747f4266e7532baf8fd02ea5db0955124d2 > > Diff: https://reviews.apache.org/r/37065/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Artem Harutyunyan > >
