-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36978/
-----------------------------------------------------------

(Updated Aug. 6, 2015, 6:20 p.m.)


Review request for mesos, Benjamin Hindman and Artem Harutyunyan.


Changes
-------

Following Ben's comments, reverted the call signature to accept varargs.


Bugs: MESOS-3142
    https://issues.apache.org/jira/browse/MESOS-3142


Repository: mesos


Description
-------

Refactoring os::shell.
See MESOS-3142 for more details.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
ab767ccc4553cc5f61e4fe1b67110a9b5b32f2bc 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/shell.hpp 
53f14e1869ed7a6e1ac7cc8a82c558ed77907dc9 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/shell.hpp 
4b7a7bafe1c64183d021b39cf12523250491f0ee 
  3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
2556bd428cc8990659e30e804b9c96c1659ef4a1 

Diff: https://reviews.apache.org/r/36978/diff/


Testing
-------

make check
*Note*: this patch by itself breaks mesos - this only fixes the `stout` part: 
see also https://reviews.apache.org/r/36979/


Thanks,

Marco Massenzio

Reply via email to