> On Aug. 7, 2015, 12:06 p.m., Alexander Rojas wrote: > > include/mesos/type_utils.hpp, line 515 > > <https://reviews.apache.org/r/37189/diff/1/?file=1033607#file1033607line515> > > > > Perhaps add a summarized version of this comment into the code?
I've added a comment to every occurence to explain the static_cast. We should keep the other options mentioned in the former comment in mind. - Jan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37189/#review94519 ----------------------------------------------------------- On Aug. 7, 2015, 12:28 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37189/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2015, 12:28 p.m.) > > > Review request for mesos, Alexander Rojas and Michael Park. > > > Bugs: MESOS-3217 > https://issues.apache.org/jira/browse/MESOS-3217 > > > Repository: mesos > > > Description > ------- > > Added std::hash template specializations. > > > Diffs > ----- > > include/mesos/type_utils.hpp f1cb5e279073c5195fc41dada307a10d00c84955 > src/linux/cgroups.hpp a651f3434b908b54d217117933740d52dbe50adf > src/master/metrics.hpp 5e96a5f71d042592524fec2151f37de28e3008ea > src/messages/log.hpp 4ddf35f9f5137eb7a9236dc9d1b4a73ba44bf61d > src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19 > src/module/manager.cpp 909ca56eea85d365cb9ebe1b3cce43051cabb670 > src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711 > src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8 > src/tests/module.hpp 03756a2536ca3e662ba422e96d121a6c39bb8c84 > > Diff: https://reviews.apache.org/r/37189/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
