> On Aug. 11, 2015, 5:39 a.m., Michael Park wrote:
> > Looks good overall! Same question as 
> > [r37188](https://reviews.apache.org/r/37188/): why did you decide to leave 
> > the `hash_value` functions and call it from `std::hash` specializations 
> > rather than moving the logic?

I assumed that there may be other functionality that depends on the 
`hash_value` functions. After moving the logic to `std::hash`, the only 
dependencies were in stout/cache.hpp and stout/multihashmap.hpp. Both also 
relied on boost, which I changed to std includes. See r37187 for the added 
changes.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/#review94859
-----------------------------------------------------------


On Aug. 11, 2015, 11:58 a.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37189/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2015, 11:58 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Michael Park.
> 
> 
> Bugs: MESOS-3217
>     https://issues.apache.org/jira/browse/MESOS-3217
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added std::hash template specializations.
> 
> 
> Diffs
> -----
> 
>   include/mesos/type_utils.hpp 6ff061c94e9d3dbb55bd047840b2012d11e3a0f2 
>   src/linux/cgroups.hpp 91ccfd046256d29504e93003de83c04f048c9b78 
>   src/master/metrics.hpp c51887ee1e072a063d629a735a3c6a2212e616ef 
>   src/messages/log.hpp 94e38c189703ff22c412b86429e052e942e75e75 
>   src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19 
>   src/module/manager.cpp 909ca56eea85d365cb9ebe1b3cce43051cabb670 
>   src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711 
>   src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8 
>   src/tests/module.hpp 03756a2536ca3e662ba422e96d121a6c39bb8c84 
> 
> Diff: https://reviews.apache.org/r/37189/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Reply via email to