-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36050/#review94665
-----------------------------------------------------------


As I mentioned in https://reviews.apache.org/r/36048/, I think it might make 
sense to provide a `authorization` module in which `authorizer` is a member of.
Similar to the relationship between the `authentication` module and its 
members: `authenticatee` and `authenticator`.

In the context of this patch, I'm suggesting that we could have 
`examples/test_authorizer_module.cpp`, `addAuthorizationModules`, etc instead,
and keep the authorizer itself as `TestLocalAuthorizer`.


src/examples/test_authorizer_module.cpp (line 33)
<https://reviews.apache.org/r/36050/#comment149275>

    Remove new line.



src/examples/test_authorizer_module.cpp (line 35)
<https://reviews.apache.org/r/36050/#comment149276>

    `s/nullptr/NULL/`



src/tests/authorization_tests.cpp (line 43)
<https://reviews.apache.org/r/36050/#comment149274>

    `s/AuthorizerTestTypes/AuthorizerTypes/`?


- Michael Park


On Aug. 5, 2015, 9:04 a.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36050/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2015, 9:04 a.m.)
> 
> 
> Review request for mesos, Adam B, Bernd Mathiske, Jan Schlicht, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-2947
>     https://issues.apache.org/jira/browse/MESOS-2947
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds a test authorizer module.
> 
> Updates the authorization tests in order to perform typed tests on the 
> default authorizer implementation and on the test authorizer module.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec 
>   src/examples/test_authorizer_module.cpp PRE-CREATION 
>   src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 
>   src/tests/module.hpp 03756a2536ca3e662ba422e96d121a6c39bb8c84 
>   src/tests/module.cpp 61d4753f0f098005f56dd4a24984e30405c32558 
> 
> Diff: https://reviews.apache.org/r/36050/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Reply via email to