----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37273/#review94776 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/CMakeLists.txt (line 55) <https://reviews.apache.org/r/37273/#comment149371> Sorry, maybe I'm a bit slow this morning -- but how are you running this? Windows doesn't have the `patch` utility, right? How does this actually get patched on Windows? 3rdparty/libprocess/3rdparty/CMakeLists.txt (line 74) <https://reviews.apache.org/r/37273/#comment149370> So, why change the value to `TRUE` here? Is there some consequence of this, or is it just clearer to you? (Also, if we want to go this way, it probably makes sense to change the `""` we use in the `ExternalProject_Add` calls as well, just for consistency.) 3rdparty/libprocess/3rdparty/glog-0.3.3.patch (line 21) <https://reviews.apache.org/r/37273/#comment149369> Looks like your updating the patchfile here to include my glog PR that opens it to working on MSVC 1900? I actually have an open review for this, here[1], but I take a different approach. I'd be grateful for your feedback, but it's a bit stale -- now that there's an "official" patch in the works, we can just tell the Windows port to point at the version of glog that includes that patch. 3rdparty/libprocess/cmake/macros/VsBuildCommand.bat (line 1) <https://reviews.apache.org/r/37273/#comment149372> In glog's solution, you're required to migrate the project to VS2015 before building it. Does this script do that automatically? (Sorry about the noob question, I don't actually know how this works.) - Alex Clemmer On Aug. 10, 2015, 9:50 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37273/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2015, 9:50 a.m.) > > > Review request for mesos and Alex Clemmer. > > > Repository: mesos > > > Description > ------- > > Add CMake macro VsBuildCommand in libprocess. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/CMakeLists.txt > 997cc0d0e316e316136d4746e50e9e292a82b36b > 3rdparty/libprocess/3rdparty/glog-0.3.3.patch > 76b8c0fe3b4615371e265bab713d62c896b7c3d6 > 3rdparty/libprocess/3rdparty/protobuf-2.5.0.patch PRE-CREATION > 3rdparty/libprocess/cmake/ProcessConfigure.cmake > 12506a1369de005285268f895f365aba0c560f78 > 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake > 9e4dcb83a8cc4e95a2a38573944f6b38e2eac76e > 3rdparty/libprocess/cmake/macros/VsBuildCommand.bat PRE-CREATION > 3rdparty/libprocess/cmake/macros/VsBuildCommand.cmake PRE-CREATION > > Diff: https://reviews.apache.org/r/37273/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
