-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37311/#review94814
-----------------------------------------------------------



src/slave/containerizer/provisioners/appc/store.cpp (line 63)
<https://reviews.apache.org/r/37311/#comment149447>

    This is a unordered list of layers for this image then? Who is keeping the 
order of the dependencies?



src/slave/containerizer/provisioners/appc/store.cpp (line 191)
<https://reviews.apache.org/r/37311/#comment149446>

    This has the exact same message from line 197, perhaps we can have 
different messages so it's easier to know if it's just a directory check 
problem or actual file content problem



src/tests/containerizer/appc_provisioner_tests.cpp (line 119)
<https://reviews.apache.org/r/37311/#comment149445>

    Btw looking at this and the read-only store, is there documentation around 
how users can potentially use this like a user guide?


- Timothy Chen


On Aug. 10, 2015, 7:19 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37311/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2015, 7:19 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-3194
>     https://issues.apache.org/jira/browse/MESOS-3194
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented a 'read-only' Appc image store.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 942003149b071a322933e2c085d9122903f69713 
>   src/slave/containerizer/provisioners/appc/store.hpp PRE-CREATION 
>   src/slave/containerizer/provisioners/appc/store.cpp PRE-CREATION 
>   src/slave/flags.hpp 881d494c06fea5c382d27b357d65c1baf201ae46 
>   src/slave/flags.cpp 82b6cf47af26f0533ff603a67240777e9a9b986e 
>   src/tests/containerizer/appc_provisioner_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37311/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Reply via email to