-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37311/#review95340
-----------------------------------------------------------

Ship it!



src/slave/containerizer/provisioners/appc/store.cpp (lines 74 - 75)
<https://reviews.apache.org/r/37311/#comment150251>

    Please wrap the comments so that it's less jagged (e.g., wrapping at 70 
char)



src/slave/containerizer/provisioners/appc/store.cpp (lines 78 - 79)
<https://reviews.apache.org/r/37311/#comment150252>

    Ditto here.



src/slave/containerizer/provisioners/appc/store.cpp (lines 119 - 120)
<https://reviews.apache.org/r/37311/#comment150250>

    Please make the comment here less jagged (e.g., wrapping at 70 char).



src/slave/containerizer/provisioners/appc/store.cpp (line 121)
<https://reviews.apache.org/r/37311/#comment150254>

    s/createEntry/createImage/?


- Jie Yu


On Aug. 13, 2015, 9:39 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37311/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2015, 9:39 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, Jojy Varghese, and 
> Timothy Chen.
> 
> 
> Bugs: MESOS-3194
>     https://issues.apache.org/jira/browse/MESOS-3194
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented a 'read-only' Appc image store.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 942003149b071a322933e2c085d9122903f69713 
>   src/slave/containerizer/provisioners/appc/store.hpp PRE-CREATION 
>   src/slave/containerizer/provisioners/appc/store.cpp PRE-CREATION 
>   src/slave/flags.hpp 881d494c06fea5c382d27b357d65c1baf201ae46 
>   src/slave/flags.cpp 82b6cf47af26f0533ff603a67240777e9a9b986e 
>   src/tests/containerizer/appc_provisioner_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37311/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Reply via email to