> On Aug. 12, 2015, 6:04 a.m., Bernd Mathiske wrote: > > include/mesos/authorizer/authorizer.hpp, line 49 > > <https://reviews.apache.org/r/36048/diff/15/?file=1036353#file1036353line49> > > > > If this is only relevant for the default implementation, then this > > method should be declared there, not here.
Well. I can see why we need this method declared here. It becomes clear in the subsequent patch: we have a module system structure that requires it. Can you maybe explain in your comment here what the reason for declaring a method that is only used in one case is? - Bernd ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/#review95079 ----------------------------------------------------------- On Aug. 10, 2015, 7:35 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36048/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2015, 7:35 a.m.) > > > Review request for mesos, Adam B, Alexander Rukletsov, Bernd Mathiske, Kapil > Arya, Jan Schlicht, and Till Toenshoff. > > > Bugs: MESOS-2946 > https://issues.apache.org/jira/browse/MESOS-2946 > > > Repository: mesos > > > Description > ------- > > Splits and updates the original declaration of the `Authorizer` into its > interface and a default implementation, the `LocalAuthorizer`. > > Following the pattern of the modularized `Authenticator`, it generates a > default constructor which is required when writing a `TYPED_TEST` in > a follow up patch. Additionally, an initialize method has been added, needed > for passing in the current ACL definitions as provided via > flags. > > Other changes are just updates to allow for compilation. > > > Diffs > ----- > > include/mesos/authorizer/authorizer.hpp PRE-CREATION > include/mesos/authorizer/authorizer.proto PRE-CREATION > include/mesos/mesos.proto 80f56ac2178b24ff19f57c1ace13f567843c7807 > include/mesos/type_utils.hpp 6ff061c94e9d3dbb55bd047840b2012d11e3a0f2 > src/Makefile.am 942003149b071a322933e2c085d9122903f69713 > src/authorizer/authorizer.hpp c039d9412780aa199db169b31991bf9f45b07d0f > src/authorizer/authorizer.cpp 21e97e315478a4ca9442af83732665f85eb2f8fc > src/common/parse.hpp 8d7ddd6819dad98cd96d5aaae8fe57caf1ee7098 > src/examples/persistent_volume_framework.cpp > c6d6ed337bfca91dc146cb31298cabebdbb13509 > src/local/local.cpp 1953d84c75a83f4ace944d6243456235d8a193ff > src/master/flags.hpp f2cd19a6edfaa4e5bb31f024ef8d5beda32fbc2f > src/master/http.cpp 1702b07d11c578cfee31871521106501c8eec357 > src/master/main.cpp e05a472b86170eb26df26aaa4b65437fcdd413ce > src/master/master.hpp 10cc100b1cf10aa7a8a9979a2562a9c5a9e55bd6 > src/master/master.cpp 08dd34d9d18f547c6e8d04caf9e39a2b3ffc5f63 > src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 > src/tests/cluster.hpp 422ebd17da045002294e67027e9ebe1377bc53cd > src/tests/mesos.hpp 8b486145dfd2a554689f6e84d76b50508979fea2 > src/tests/mesos.cpp a2a469e2a581dc6c566dafd4acd2a95c0238399f > > Diff: https://reviews.apache.org/r/36048/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
