reviews
Thread
Date
Earlier messages
Later messages
Messages by Thread
Re: Review Request 71956: Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.
Qian Zhang
Re: Review Request 71956: Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.
Qian Zhang
Re: Review Request 71956: Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.
Qian Zhang
Re: Review Request 71956: Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.
Qian Zhang
Re: Review Request 71955: Add a new parameter `resourceLimits` to the `createTask` methods.
Greg Mann
Re: Review Request 71955: Add a new parameter `resourceLimits` to the `createTask` methods.
Greg Mann
Re: Review Request 71955: Added a new parameter `resourceLimits` to the `createTask` methods.
Qian Zhang
Re: Review Request 71951: Added resource limits into the `Task` protobuf message.
Greg Mann
Re: Review Request 71951: Added resource limits into the `Task` protobuf message.
Qian Zhang
Re: Review Request 71951: Added resource limits into the `Task` protobuf message.
Greg Mann
Re: Review Request 71951: Added resource limits into the `Task` protobuf message.
Qian Zhang
Re: Review Request 71885: Updated the `update()` method of subsystem to handle resource limits.
Greg Mann
Re: Review Request 71885: Updated the `update()` method of subsystem to handle resource limits.
Qian Zhang
Re: Review Request 71884: Updated the `update()` method of isolator to handle resource limits.
Greg Mann
Re: Review Request 71884: Updated the `update()` method of isolator to handle resource limits.
Qian Zhang
Review Request 72196: Removed stale MPI framework.
Vinod Kone
Re: Review Request 72196: Removed stale MPI framework.
Benjamin Mahler
Review Request 72190: Added a test `LaunchNestedShareCgroups`.
Andrei Budnik
Re: Review Request 72190: Added a test `LaunchNestedShareCgroups`.
Mesos Reviewbot
Re: Review Request 72190: Added a test `LaunchNestedShareCgroups`.
Mesos Reviewbot
Re: Review Request 72190: Added a test `LaunchNestedShareCgroups`.
Mesos Reviewbot
Re: Review Request 72190: Added a test `LaunchNestedShareCgroups`.
Qian Zhang
Re: Review Request 72190: Added a test `LaunchNestedShareCgroups`.
Mesos Reviewbot
Review Request 72189: Updated nested mesos containerizer tests to support `shared_cgroups`.
Andrei Budnik
Re: Review Request 72189: Updated nested mesos containerizer tests to support `shared_cgroups`.
Qian Zhang
Re: Review Request 72189: Updated nested mesos containerizer tests to support `shared_cgroups`.
Greg Mann
Review Request 72187: Fixed build on platforms not treating initializer_list<enum> as literal.
Andrei Sekretenko
Re: Review Request 72187: Fixed build on platforms not treating initializer_list<enum> as literal.
Benjamin Mahler
Re: Review Request 72187: Fixed build on platforms not treating initializer_list<enum> as literal.
Andrei Sekretenko
Re: Review Request 72187: Fixed build on platforms not treating initializer_list<enum> as literal.
Benjamin Mahler
Re: Review Request 72187: Fixed build on platforms not treating initializer_list<enum> as literal.
Mesos Reviewbot
Review Request 72185: Disabled RoleTest.RolesEndpointContainsConsumedQuota on Windows.
Andrei Sekretenko
Re: Review Request 72185: Disabled RoleTest.RolesEndpointContainsConsumedQuota on Windows.
Benjamin Mahler
Re: Review Request 72185: Disabled RoleTest.RolesEndpointContainsConsumedQuota on Windows.
Andrei Sekretenko
Re: Review Request 72185: Disabled RoleTest.RolesEndpointContainsConsumedQuota on Windows.
Mesos Reviewbot
Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs` to check CFS quota.
Greg Mann
Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs` to check CFS quota.
Greg Mann
Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs` to check CFS quota.
Qian Zhang
Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs` to check CFS quota.
Greg Mann
Review Request 72179: Got rid of passing Shared<> into `Subscribers::Subscriber::send(...)`.
Andrei Sekretenko
Re: Review Request 72179: Got rid of passing Shared<> into `Subscribers::Subscriber::send(...)`.
Benjamin Mahler
Re: Review Request 72179: Got rid of passing Shared<> into `Subscribers::Subscriber::send(...)`.
Mesos Reviewbot
Review Request 72178: Converted sending operator API events to synchronous authorization.
Andrei Sekretenko
Re: Review Request 72178: Converted sending operator API events to synchronous authorization.
Benjamin Mahler
Review Request 72170: Added test for removal of ObjectApprovers of disconnected framework.
Andrei Sekretenko
Re: Review Request 72170: Added test for removal of ObjectApprovers of disconnected framework.
Andrei Sekretenko
Re: Review Request 72170: Added test for removal of ObjectApprovers of disconnected framework.
Mesos Reviewbot
Re: Review Request 72170: Added test for removal of ObjectApprovers of disconnected framework.
Benjamin Mahler
Re: Review Request 72170: Added test for removal of ObjectApprovers of disconnected framework.
Mesos Reviewbot
Review Request 72169: Made `overload()` work with callables passed by reference.
Andrei Sekretenko
Re: Review Request 72169: Made `overload()` work with callables passed by reference.
Benjamin Mahler
Re: Review Request 71950: Updated containerizer's `update()` method to handle resource limits.
Greg Mann
Re: Review Request 71950: Updated containerizer's `update()` method to handle resource limits.
Qian Zhang
Re: Review Request 71950: Updated containerizer's `update()` method to handle resource limits.
Greg Mann
Re: Review Request 71950: Updated containerizer's `update()` method to handle resource limits.
Greg Mann
Re: Review Request 71950: Updated containerizer's `update()` method to handle resource limits.
Qian Zhang
Re: Review Request 71950: Updated containerizer's `update()` method to handle resource limits.
Qian Zhang
Re: Review Request 71952: Set resource limits when updating executor container.
Qian Zhang
Re: Review Request 71952: Set resource limits when updating executor container.
Greg Mann
Re: Review Request 71952: Set resource limits when updating executor container.
Greg Mann
Re: Review Request 71952: Set resource limits when updating executor container.
Greg Mann
Re: Review Request 71952: Set resource limits when updating executor container.
Qian Zhang
Re: Review Request 71952: Set resource limits when updating executor container.
Greg Mann
Re: Review Request 71952: Set resource limits when updating executor container.
Qian Zhang
Re: Review Request 72022: Set resource limits and OOM score adjustment in Docker executor.
Qian Zhang
Re: Review Request 72022: Set resource limits and OOM score adjustment in Docker executor.
Greg Mann
Re: Review Request 72022: Set resource limits and OOM score adjustment in Docker executor.
Qian Zhang
Re: Review Request 72022: Set resource limits and OOM score adjustment in Docker executor.
Greg Mann
Re: Review Request 72022: Set resource limits and OOM score adjustment in Docker executor.
Qian Zhang
Re: Review Request 72022: Set resource limits and OOM score adjustment in Docker executor.
Qian Zhang
Re: Review Request 72022: Set resource limits and OOM score adjustment in Docker executor.
Greg Mann
Re: Review Request 72022: Set resource limits and OOM score adjustment in Docker executor.
Qian Zhang
Re: Review Request 72022: Set resource limits and OOM score adjustment in Docker executor.
Greg Mann
Re: Review Request 72022: Set resource limits and OOM score adjustment in Docker executor.
Greg Mann
Re: Review Request 71944: Set container process's OOM score adjust.
Qian Zhang
Re: Review Request 71944: Set container process's OOM score adjust.
Greg Mann
Re: Review Request 71944: Set container process's OOM score adjust.
Qian Zhang
Re: Review Request 71944: Set container process's OOM score adjust.
Qian Zhang
Re: Review Request 71944: Set container process's OOM score adjust.
Qian Zhang
Re: Review Request 71944: Set container process's OOM score adjust.
Qian Zhang
Re: Review Request 71944: Set container process's OOM score adjust.
Greg Mann
Re: Review Request 71943: Set container's `memory.limit_in_bytes` to its memory limit.
Qian Zhang
Re: Review Request 71943: Set container's `memory.limit_in_bytes` to its memory limit.
Greg Mann
Re: Review Request 71943: Set container's `memory.limit_in_bytes` to its memory limit.
Greg Mann
Re: Review Request 71943: Set container's `memory.limit_in_bytes` to its memory limit.
Qian Zhang
Re: Review Request 71943: Set container's `memory.limit_in_bytes` to its memory limit.
Qian Zhang
Re: Review Request 71943: Set container's `memory.limit_in_bytes` to its memory limit.
Greg Mann
Re: Review Request 71943: Set container's `memory.limit_in_bytes` to its memory limit.
Qian Zhang
Re: Review Request 71886: Set container's `cpu.cfs_quota_us` to its CPU resource limit.
Qian Zhang
Re: Review Request 71886: Set container's `cpu.cfs_quota_us` to its CPU resource limit.
Qian Zhang
Re: Review Request 71886: Set container's `cpu.cfs_quota_us` to its CPU resource limit.
Greg Mann
Re: Review Request 71886: Set container's `cpu.cfs_quota_us` to its CPU resource limit.
Qian Zhang
Re: Review Request 71886: Set container's `cpu.cfs_quota_us` to its CPU resource limit.
Greg Mann
Re: Review Request 71886: Set container's `cpu.cfs_quota_us` to its CPU resource limit.
Qian Zhang
Re: Review Request 71886: Set container's `cpu.cfs_quota_us` to its CPU resource limit.
Qian Zhang
Re: Review Request 71858: Set resource limits when launching executor container.
Qian Zhang
Re: Review Request 71858: Set resource limits when launching executor container.
Qian Zhang
Re: Review Request 71858: Set resource limits when launching executor container.
Greg Mann
Re: Review Request 71858: Set resource limits when launching executor container.
Qian Zhang
Re: Review Request 71858: Set resource limits when launching executor container.
Greg Mann
Re: Review Request 71858: Set resource limits when launching executor container.
Qian Zhang
Re: Review Request 71858: Set resource limits when launching executor container.
Greg Mann
Re: Review Request 71858: Set resource limits when launching executor container.
Qian Zhang
Re: Review Request 71858: Set resource limits when launching executor container.
Greg Mann
Re: Review Request 71858: Set resource limits when launching executor container.
Greg Mann
Re: Review Request 71858: Set resource limits when launching executor container.
Qian Zhang
Re: Review Request 71858: Set resource limits when launching executor container.
Greg Mann
Re: Review Request 71858: Set resource limits when launching executor container.
Qian Zhang
Re: Review Request 71858: Set resource limits when launching executor container.
Greg Mann
Re: Review Request 71858: Set resource limits when launching executor container.
Qian Zhang
Re: Review Request 71858: Set resource limits when launching executor container.
Greg Mann
Re: Review Request 71858: Set resource limits when launching executor container.
Qian Zhang
Re: Review Request 71858: Set resource limits when launching executor container.
Greg Mann
Re: Review Request 71858: Set resource limits when launching executor container.
Qian Zhang
Re: Review Request 71858: Set resource limits when launching executor container.
Greg Mann
Review Request 72162: Accommodated the "Infinity" value in the JSON <-> Protobuf conversion.
Qian Zhang
Re: Review Request 72162: Accommodated the "Infinity" value in the JSON <-> Protobuf conversion.
Andrei Budnik
Re: Review Request 72162: Accommodated the "Infinity" value in the JSON <-> Protobuf conversion.
Greg Mann
Re: Review Request 72162: Accommodated the "Infinity" value in the JSON <-> Protobuf conversion.
Qian Zhang
Re: Review Request 72162: Accommodated the "Infinity" value in the JSON <-> Protobuf conversion.
Qian Zhang
Re: Review Request 72162: Accommodated the "Infinity" value in the JSON <-> Protobuf conversion.
Andrei Budnik
Re: Review Request 72162: Accommodated the "Infinity" value in the JSON <-> Protobuf conversion.
Greg Mann
Re: Review Request 72162: Accommodated the "Infinity" value in the JSON <-> Protobuf conversion.
Qian Zhang
Re: Review Request 72162: Accommodated the "Infinity" value in the JSON <-> Protobuf conversion.
Qian Zhang
Re: Review Request 72162: Accommodated the "Infinity" value in the JSON <-> Protobuf conversion.
Qian Zhang
Re: Review Request 72162: Accommodated the "Infinity" value in the JSON <-> Protobuf conversion.
Greg Mann
Re: Review Request 72162: Accommodated the "Infinity" value in the JSON <-> Protobuf conversion.
Qian Zhang
Re: Review Request 72162: Accommodated the "Infinity" value in the JSON <-> Protobuf conversion.
Qian Zhang
Review Request 72161: Added patch for RapidJSON.
Qian Zhang
Re: Review Request 72161: Added patch for RapidJSON.
Greg Mann
Re: Review Request 72161: Added patch for RapidJSON.
Qian Zhang
Re: Review Request 72161: Added patch for RapidJSON.
Benjamin Bannier
Re: Review Request 72161: Added patch for RapidJSON.
Greg Mann
Re: Review Request 72161: Added patch for RapidJSON.
Qian Zhang
Re: Review Request 72161: Added patch for RapidJSON.
Qian Zhang
Re: Review Request 72161: Added patch for RapidJSON.
Greg Mann
Re: Review Request 72161: Added patch for RapidJSON.
Qian Zhang
Re: Review Request 72161: Added patch for RapidJSON.
Greg Mann
Re: Review Request 72161: Added patch for RapidJSON.
Qian Zhang
[GitHub] [mesos] dharmeshkakadia opened a new pull request #350: Fix book thumbnail link
GitBox
Review Request 72157: Removed reimplementation of `cloexec` code in systemd activation code.
Andrei Budnik
Re: Review Request 72157: Removed reimplementation of `cloexec` from systemd activation code.
Andrei Sekretenko
Re: Review Request 72157: Removed reimplementation of `cloexec` from systemd activation code.
Andrei Budnik
Re: Review Request 72157: Removed reimplementation of `cloexec` from systemd activation code.
Andrei Budnik
Review Request 72158: Fixed systemd socket activation on old systemd versions.
Andrei Budnik
Re: Review Request 72158: Fixed systemd socket activation on old systemd versions.
Mesos Reviewbot
Re: Review Request 72158: Fixed systemd socket activation on old systemd versions.
Mesos Reviewbot
Re: Review Request 72158: Fixed systemd socket activation on old systemd versions.
Andrei Sekretenko
Re: Review Request 72158: Fixed systemd socket activation on old systemd versions.
Andrei Budnik
Re: Review Request 72158: Fixed systemd socket activation on old systemd versions.
Andrei Budnik
Re: Review Request 72158: Fixed systemd socket activation on old systemd versions.
Andrei Budnik
Re: Review Request 72158: Fixed systemd socket activation on old systemd versions.
Mesos Reviewbot
Re: Review Request 72158: Fixed systemd socket activation on old systemd versions.
Andrei Sekretenko
Review Request 72130: Added heartbeater deletion when HTTP framework is disconnected.
Andrei Sekretenko
Re: Review Request 72130: Added heartbeater deletion when HTTP framework is disconnected.
Benjamin Mahler
Review Request 72126: Added a test to ensure agents cannot be reactivated while DRAINING.
Benjamin Mahler
Re: Review Request 72126: Added a test to ensure agents cannot be reactivated while DRAINING.
Mesos Reviewbot
Re: Review Request 72126: Added a test to ensure agents cannot be reactivated while DRAINING.
Joseph Wu
Review Request 72125: Disallow reactivating a DRAINING agent.
Benjamin Mahler
Re: Review Request 72125: Disallow reactivating a DRAINING agent.
Joseph Wu
Review Request 72124: Added logging of tasks and operations during agent drain initiation.
Benjamin Mahler
Re: Review Request 72124: Added logging of tasks and operations during agent drain initiation.
Mesos Reviewbot
Re: Review Request 72124: Added logging of tasks and operations during agent drain initiation.
Joseph Wu
Review Request 72122: Fixed `cgroups::create` for nested cgroups.
Andrei Budnik
Re: Review Request 72122: Fixed `cgroups::create` for nested cgroups.
Mesos Reviewbot
Re: Review Request 72122: Fixed `cgroups::create` for nested cgroups.
Mesos Reviewbot
Re: Review Request 72122: Fixed `cgroups::create` for nested cgroups.
Mesos Reviewbot
Re: Review Request 72122: Fixed `cgroups::create` for nested cgroups.
Mesos Reviewbot
Re: Review Request 72122: Fixed `cgroups::create` for nested cgroups.
Mesos Reviewbot
Re: Review Request 72122: Fixed `cgroups::create` for nested cgroups.
Qian Zhang
Re: Review Request 72122: Fixed `cgroups::create` for nested cgroups.
Andrei Budnik
Review Request 72121: Moved cgroup path helpers to `paths.hpp`.
Andrei Budnik
Re: Review Request 72121: Moved cgroup path helpers to `paths.hpp`.
Qian Zhang
Re: Review Request 71966: Cgroups isolator: added support for nested cgroups during recovery.
Andrei Budnik
Re: Review Request 71966: Cgroups isolator: added support for nested cgroups during recovery.
Qian Zhang
Re: Review Request 71966: Cgroups isolator: added support for nested cgroups during recovery.
Qian Zhang
Re: Review Request 71966: Cgroups isolator: added support for nested cgroups during recovery.
Andrei Budnik
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Andrei Budnik
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Andrei Budnik
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Qian Zhang
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Greg Mann
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Qian Zhang
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Andrei Budnik
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Greg Mann
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Qian Zhang
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Greg Mann
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Greg Mann
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Qian Zhang
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Qian Zhang
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Qian Zhang
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Qian Zhang
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Andrei Budnik
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Andrei Budnik
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Andrei Budnik
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Andrei Budnik
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Andrei Budnik
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Qian Zhang
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Andrei Budnik
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Andrei Budnik
Review Request 72116: Fixed incorrect task count logging in master's agent draining logic.
Benjamin Mahler
Earlier messages
Later messages