> On Aug. 13, 2015, 6:24 a.m., Lily Chen wrote: > > src/slave/containerizer/provisioners/docker/token_manager.cpp, line 252 > > <https://reviews.apache.org/r/37427/diff/2/?file=1039212#file1039212line252> > > > > space between () {}, you could also probably just do this in the header > > file
The reason we dont add definition in header file is that compiler might add the definition in each compilation unit the header file is included. This will bloat the binary (and other issues that comes along with it). - Jojy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37427/#review95238 ----------------------------------------------------------- On Aug. 13, 2015, 8:29 a.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37427/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2015, 8:29 a.m.) > > > Review request for mesos, Lily Chen and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > Changes: > - Added Token implementation (RFC 7519). > - Added TokenManager implementation. This component keeps a cache of tokens > requested for any future requests. > > > Diffs > ----- > > src/Makefile.am 111aed92820689b12ee4073269ce34db7be30960 > src/slave/containerizer/provisioners/docker/token_manager.hpp PRE-CREATION > src/slave/containerizer/provisioners/docker/token_manager.cpp PRE-CREATION > src/tests/containerizer/docker_containerizer_tests.cpp > c8c27a64c06cf37bdaa5b474ea25bd2e971c8fea > > Diff: https://reviews.apache.org/r/37427/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jojy Varghese > >
