-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37427/#review95326
-----------------------------------------------------------



src/slave/containerizer/provisioners/docker/token_manager.hpp (line 48)
<https://reviews.apache.org/r/37427/#comment150235>

    Move class variables after the method declarations



src/slave/containerizer/provisioners/docker/token_manager.hpp (line 82)
<https://reviews.apache.org/r/37427/#comment150231>

    Name the parameters,
    also 4 space indent and one parameter each line.



src/slave/containerizer/provisioners/docker/token_manager.hpp (line 93)
<https://reviews.apache.org/r/37427/#comment150232>

    Nit: I think we usually comment Forward declarations (although I don't 
think it's in the style guide)



src/slave/containerizer/provisioners/docker/token_manager.cpp (line 120)
<https://reviews.apache.org/r/37427/#comment150237>

    Let's not use auto here, spell out the type.



src/slave/containerizer/provisioners/docker/token_manager.cpp (line 122)
<https://reviews.apache.org/r/37427/#comment150236>

    This should fit in one line



src/tests/containerizer/docker_containerizer_tests.cpp (line 86)
<https://reviews.apache.org/r/37427/#comment150239>

    Add a TODO around these that we can move this into a common test SSL server 
utility.



src/tests/containerizer/docker_containerizer_tests.cpp (line 2998)
<https://reviews.apache.org/r/37427/#comment150238>

    Let's just create a new Docker provisioner test file for this.


- Timothy Chen


On Aug. 13, 2015, 8:55 p.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37427/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2015, 8:55 p.m.)
> 
> 
> Review request for mesos, Lily Chen, Joris Van Remoortere, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Changes:
>   - Added Token implementation (RFC 7519).
>   - Added TokenManager implementation. This component keeps a cache of tokens
>   requested for any future requests.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 111aed92820689b12ee4073269ce34db7be30960 
>   src/slave/containerizer/provisioners/docker/token_manager.hpp PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/token_manager.cpp PRE-CREATION 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> c8c27a64c06cf37bdaa5b474ea25bd2e971c8fea 
> 
> Diff: https://reviews.apache.org/r/37427/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Reply via email to