-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37414/#review95459
-----------------------------------------------------------

Ship it!


Per Greg, the underlying issue will be tracked here: 
https://issues.apache.org/jira/browse/MESOS-3264

Since this change makes the test less flaky, I say it LGTM.

- Joseph Wu


On Aug. 13, 2015, 9:49 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37414/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2015, 9:49 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere, Joseph Wu, and Till Toenshoff.
> 
> 
> Bugs: MESOS-1013
>     https://issues.apache.org/jira/browse/MESOS-1013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix flaky ExamplesTest.JavaLog
> 
> 
> Diffs
> -----
> 
>   src/examples/java/TestLog.java 9dd4630745e4638f5c347c8a69eec30fdad3af56 
> 
> Diff: https://reviews.apache.org/r/37414/diff/
> 
> 
> Testing
> -------
> 
> This test may fail only infrequently, and the bug is made worse by verbose 
> logging, so to verify correctness (or reproduce the bug before patching) try:
> 
> GLOG_v=2 GTEST_FILTER="ExamplesTest.JavaLog" bin/mesos-tests.sh --verbose 
> --gtest_repeat=100 2>/dev/null | grep "\["
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Reply via email to