----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37414/#review95547 -----------------------------------------------------------
Ship it! Definitely a band-aid but given that we keep tracking this for a "proper" fix, I'ld say it is an improvement already worth committing :). Thanks a bunch Greg! - Till Toenshoff On Aug. 13, 2015, 4:49 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37414/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2015, 4:49 p.m.) > > > Review request for mesos, Joris Van Remoortere, Joseph Wu, and Till Toenshoff. > > > Bugs: MESOS-1013 > https://issues.apache.org/jira/browse/MESOS-1013 > > > Repository: mesos > > > Description > ------- > > Fix flaky ExamplesTest.JavaLog > > > Diffs > ----- > > src/examples/java/TestLog.java 9dd4630745e4638f5c347c8a69eec30fdad3af56 > > Diff: https://reviews.apache.org/r/37414/diff/ > > > Testing > ------- > > This test may fail only infrequently, and the bug is made worse by verbose > logging, so to verify correctness (or reproduce the bug before patching) try: > > GLOG_v=2 GTEST_FILTER="ExamplesTest.JavaLog" bin/mesos-tests.sh --verbose > --gtest_repeat=100 2>/dev/null | grep "\[" > > > Thanks, > > Greg Mann > >
