> On Aug. 16, 2015, 6:53 a.m., Timothy Chen wrote:
> > I think other than the minor issues I see this seems to good to go, once 
> > you fix this I'll run this locally and this should be ready to go.

The jenkins seems have problem. https://builds.apache.org/job/Mesos/705/ The 
job hang 2 days. I could pass make -j8 distcheck local, and not sure the 
reviewbot failure because by my patch or others.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36185/#review95537
-----------------------------------------------------------


On Aug. 16, 2015, 7:15 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36185/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2015, 7:15 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-2588
>     https://issues.apache.org/jira/browse/MESOS-2588
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Create pre-launch hook before a docker container launches in slave.
> 
> 
> Diffs
> -----
> 
>   include/mesos/hook.hpp 6c3861b1ca82f0b5488bd2e766b1c5abc4fd7582 
>   src/examples/test_hook_module.cpp 2f0a1a04e26b6f8e250560befab5921c89149edd 
>   src/hook/manager.hpp df32484fdf1de0cec8022546ef63b81c29e53ce4 
>   src/hook/manager.cpp 0b693d2564310d2a71f31e991672117d91983452 
>   src/slave/containerizer/docker.hpp e7436d054a5b3f29cb7d2d455f00e7cb3b734d97 
>   src/slave/containerizer/docker.cpp 8f5d302477b216df9ac2f59156304bbc4a96f24b 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> c8c27a64c06cf37bdaa5b474ea25bd2e971c8fea 
>   src/tests/hook_tests.cpp e9f1c777153b94eebea0f2c4fc2f4afb0e382afb 
>   src/tests/mesos.hpp 64987f0cc1632eb8b0c2cccd8446a5324127910c 
> 
> Diff: https://reviews.apache.org/r/36185/diff/
> 
> 
> Testing
> -------
> 
> # Add a new unit test "HookTest.ROOT_DOCKER_VerifySlavePreLaunchDockerHook"
> make check -j8 GTEST_FILTER=-"*"
> sudo ./bin/mesos-tests.sh --verbose 
> --gtest_filter=HookTest.ROOT_DOCKER_VerifySlavePreLaunchDockerHook
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Reply via email to