> On Aug. 17, 2015, 5:45 p.m., Joseph Wu wrote:
> > 3rdparty/libprocess/3rdparty/CMakeLists.txt, line 174
> > <https://reviews.apache.org/r/37502/diff/1/?file=1041030#file1041030line174>
> >
> >     I believe you need some more quotation marks.  (So that the C++flags 
> > get properly assigned)
> >     
> >     i.e. 
> >     ```
> >     set(GMOCK_CONFIG_CMD "${GMOCK_ROOT}/configure
> >                          ^
> >       --prefix=${GMOCK_ROOT}-lib/lib
> >       CXXFLAGS=\"${GMOCK_CONFIG_CXXFLAGS}\" "
> >                 ^                         ^ ^
> >     ```

Actually not need, I found " have some strange behaviour here.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37502/#review95599
-----------------------------------------------------------


On Aug. 15, 2015, 12:07 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37502/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2015, 12:07 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-3270
>     https://issues.apache.org/jira/browse/MESOS-3270
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add CMAKE_CXX_FLAGS to GMOCK_CONFIG_CMD in CMake.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt 
> 997cc0d0e316e316136d4746e50e9e292a82b36b 
> 
> Diff: https://reviews.apache.org/r/37502/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Reply via email to