> On Aug. 18, 2015, 8:38 p.m., Ben Mahler wrote:
> > Paul can you split this change? I personally don't have context on why we 
> > would want to change from sampling 'true' to running against the init 
> > process so I'd like Jie or Ian to review that change, but I can help you 
> > make the refactorings to use 'Perf'. Sound good?

I will back out that change.


- Paul


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37417/#review95777
-----------------------------------------------------------


On Aug. 18, 2015, 11:01 p.m., Paul Brett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37417/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2015, 11:01 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3185
>     https://issues.apache.org/jira/browse/MESOS-3185
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Convert Perf event validator to use new shared object.
> 
> 
> Diffs
> -----
> 
>   src/linux/perf.cpp cdc5f8314a875ababf2b17a32873775d808e1c78 
> 
> Diff: https://reviews.apache.org/r/37417/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Paul Brett
> 
>

Reply via email to