----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37417/#review95806 -----------------------------------------------------------
Did you still want to use 'Perf' here? If not, I can't tell what we're gaining in this change, does supported() provide additional validation? - Ben Mahler On Aug. 18, 2015, 11:01 p.m., Paul Brett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37417/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2015, 11:01 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-3185 > https://issues.apache.org/jira/browse/MESOS-3185 > > > Repository: mesos > > > Description > ------- > > Convert Perf event validator to use new shared object. > > > Diffs > ----- > > src/linux/perf.cpp cdc5f8314a875ababf2b17a32873775d808e1c78 > > Diff: https://reviews.apache.org/r/37417/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Paul Brett > >
