> On Aug. 25, 2015, 5:51 a.m., Guangya Liu wrote:
> > src/Makefile.am, line 182
> > <https://reviews.apache.org/r/36908/diff/4/?file=1032680#file1032680line182>
> >
> >     It is better consider the alpha order of those files, we can add quota 
> > related files under module related files.
> 
> Alexander Rukletsov wrote:
>     Could you please elaborate? I'm not sure I follow.
> 
> Guangya Liu wrote:
>     I mean the file order in Makefile.am should follow alpha order as other 
> part in this file.
>     
>     My propose is that you only need to re-order the file list here as 
> following:
>     
>     module/module.pb.cc                         \
>       ../include/mesos/module/module.pb.h                   \
>     master/quota.pb.cc                          \
>       ../include/mesos/master/quota.pb.h                    \
>     
>     Just adjust the order should works.
> 
> Alexander Rukletsov wrote:
>     I see. We also include folder into lexicographic sorting, therefore 
> `module > master` and hence all `master/**` go before `module/**`. Does it 
> make sense?
> 
> Guangya Liu wrote:
>     Exactly, this can make the code more readable. I found that both Mesos 
> and OpenStack projects are following such style ;-)

Not sure I follow. Your suggestion above says to put `module/**` before 
`master/**`. Could you please elaborate what variant is more readable?


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36908/#review96299
-----------------------------------------------------------


On Aug. 5, 2015, 2:03 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36908/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2015, 2:03 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3164
>     https://issues.apache.org/jira/browse/MESOS-3164
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added QuotaInfo Protobuf.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/quota.hpp PRE-CREATION 
>   include/mesos/master/quota.proto PRE-CREATION 
>   src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec 
> 
> Diff: https://reviews.apache.org/r/36908/diff/
> 
> 
> Testing
> -------
> 
> make distcheck
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Reply via email to