----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35984/#review96503 -----------------------------------------------------------
Ship it! Awesome tests! LGTM! src/tests/reservation_endpoints_tests.cpp (line 19) <https://reviews.apache.org/r/35984/#comment151905> This is C++ header. Please put it after <string> and <vector> src/tests/reservation_endpoints_tests.cpp (lines 103 - 132) <https://reviews.apache.org/r/35984/#comment151908> This piece of code is duplicated in many tests here. Could you please pull them into a helper method in the test fixture. For instance ``` createBasicAuthHeader(); createResourcesParameter(...); ``` src/tests/reservation_endpoints_tests.cpp (line 109) <https://reviews.apache.org/r/35984/#comment151907> Are we allowed to use cxx11 raw string literals now? This is definitely better! src/tests/reservation_endpoints_tests.cpp (line 501) <https://reviews.apache.org/r/35984/#comment151911> Please move this comments right above 'Resources taskResources'. Also, could you please add a comment about why you want to launch a task here. - Jie Yu On Aug. 5, 2015, 9:55 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35984/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2015, 9:55 a.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, Joris > Van Remoortere, and Vinod Kone. > > > Bugs: MESOS-2600 > https://issues.apache.org/jira/browse/MESOS-2600 > > > Repository: mesos > > > Description > ------- > > See summary > > > Diffs > ----- > > src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec > src/tests/reservation_endpoints_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/35984/diff/ > > > Testing > ------- > > (1) Added `src/tests/reservation_endpoints_tests.cpp` > (2) `make check` > > > Thanks, > > Michael Park > >
