-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37496/#review96554
-----------------------------------------------------------


At this point I partially stopped re-raising previously raised issues -- please 
make sure you are globally fixing things I mentioned in earlier reviews within 
this chain.


src/Makefile.am (lines 755 - 759)
<https://reviews.apache.org/r/37496/#comment152046>

    Spaces vs. hard-tabs!



src/slave/containerizer/provisioners/docker/local_store.hpp (line 34)
<https://reviews.apache.org/r/37496/#comment152047>

    Kill this blank line please.



src/slave/containerizer/provisioners/docker/local_store.hpp (lines 57 - 59)
<https://reviews.apache.org/r/37496/#comment152048>

    As mentioned before, not sure we should use doxygen on these attribute 
comments.


- Till Toenshoff


On Aug. 25, 2015, 9:02 p.m., Lily Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37496/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2015, 9:02 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-2849
>     https://issues.apache.org/jira/browse/MESOS-2849
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Move docker provisioner local store into dedicated folders.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 571e1ac0f96b2452797a478680b540f2aab63aab 
>   src/slave/containerizer/provisioners/docker/local_store.hpp PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37496/diff/
> 
> 
> Testing
> -------
> 
> sudo make check 
> ./bin/mesos-tests.sh --gtest_filter="*DockerProvisioner*" --gtest_repeat=20 
> --gtest_shuffle=1
> 
> 
> Thanks,
> 
> Lily Chen
> 
>

Reply via email to