----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37496/#review97922 -----------------------------------------------------------
src/Makefile.am (lines 758 - 760) <https://reviews.apache.org/r/37496/#comment154032> Spacing seems off?! src/slave/containerizer/provisioners/docker/local_store.hpp (line 19) <https://reviews.apache.org/r/37496/#comment154033> See my earlier comment on the include-guard naming. In this particular case we are missing the `_HPP__` again. - Till Toenshoff On Aug. 27, 2015, 11:43 p.m., Lily Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37496/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2015, 11:43 p.m.) > > > Review request for mesos, Till Toenshoff and Timothy Chen. > > > Bugs: MESOS-2849 > https://issues.apache.org/jira/browse/MESOS-2849 > > > Repository: mesos > > > Description > ------- > > Move docker provisioner local store into dedicated folders. > > > Diffs > ----- > > src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 > src/slave/containerizer/provisioners/docker/local_store.hpp PRE-CREATION > src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION > src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/37496/diff/ > > > Testing > ------- > > sudo make check > ./bin/mesos-tests.sh --gtest_filter="*DockerProvisioner*" --gtest_repeat=20 > --gtest_shuffle=1 > > > Thanks, > > Lily Chen > >