-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36620/#review96734
-----------------------------------------------------------


What's the status on this review? Is it still WIP?

Would love to get this patch in given the perf ROOT tests are always broken on 
newer kernels.


src/linux/cgroups.cpp (lines 1776 - 1791)
<https://reviews.apache.org/r/36620/#comment152376>

    Could you please introduce a new function under cgroups namespace and put 
this logic there:
    
    ```
    // Kill all processes in the given cgroup.
    Future<Nothing> cgroups::kill(
        const string& hierarchy,
        const string& cgroup)
    {
      ...
      if (freezerCheckError.isNone()) {
      } else {
      }
      
      return ...;
    }
    ```
    
    You may want to rename the exsiting `cgroups::kill(hierarchy, cgroup, 
signal)` to `cgroups::signal`.


- Jie Yu


On Aug. 24, 2015, 9:33 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36620/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2015, 9:33 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Till Toenshoff, and Timothy Chen.
> 
> 
> Bugs: MESOS-3086
>     https://issues.apache.org/jira/browse/MESOS-3086
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> WIP Added Non-Freezeer Task Killer.
> 
> 
> Diffs
> -----
> 
>   src/linux/cgroups.cpp 6ef42ed1bc719f334d1ac6e90919a1bc1840d31f 
> 
> Diff: https://reviews.apache.org/r/36620/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> + manual tests
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Reply via email to