> On Aug. 24, 2015, 3:05 p.m., Alexander Rojas wrote:
> > src/linux/cgroups.cpp, line 1749
> > <https://reviews.apache.org/r/36620/diff/13/?file=1039336#file1039336line1749>
> >
> >     Do they need to be actual attributes? For example `kill()` could return 
> > a `Future<list<Future<Option<int>>>>`, and `reap()` could take a 
> > `list<Future<Option<int>>>` as parameter, then line 1686 will look:
> >     
> >     ```
> >     chain = kill(processes).then(defer(self(), &Self::reap, lambda::_1));
> >     ```
> >     
> >     and you don't need statuses to be an attribute nor do you need line 
> > 1672.

see below and discussion offline.


- Joerg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36620/#review96144
-----------------------------------------------------------


On Aug. 24, 2015, 9:33 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36620/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2015, 9:33 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Till Toenshoff, and Timothy Chen.
> 
> 
> Bugs: MESOS-3086
>     https://issues.apache.org/jira/browse/MESOS-3086
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> WIP Added Non-Freezeer Task Killer.
> 
> 
> Diffs
> -----
> 
>   src/linux/cgroups.cpp 6ef42ed1bc719f334d1ac6e90919a1bc1840d31f 
> 
> Diff: https://reviews.apache.org/r/36620/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> + manual tests
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Reply via email to