----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37655/#review96755 -----------------------------------------------------------
Ship it! include/mesos/mesos.proto (line 100) <https://reviews.apache.org/r/37655/#comment152394> How about a TODO that suggests adding time zone information? - Benjamin Hindman On Aug. 27, 2015, 8:14 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37655/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2015, 8:14 p.m.) > > > Review request for mesos, Benjamin Hindman, Bernd Mathiske, Ben Mahler, Artem > Harutyunyan, Joris Van Remoortere, and Vinod Kone. > > > Bugs: MESOS-3299 > https://issues.apache.org/jira/browse/MESOS-3299 > > > Repository: mesos > > > Description > ------- > > Instead of using doubles, time and duration can be represented as integers > for nanoseconds. > > This will be important if frameworks need to compare times to make decisions > (such as for maintenance primitives). > > Note about the naming: > > * TimeInfo will directly correspond with the Time class. > * DurationInfo will directly correspond with the Duration class. > > > Diffs > ----- > > include/mesos/mesos.proto 715b8cf38e1e56c18a3f2ddbb82c920bd9414f05 > include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321 > > Diff: https://reviews.apache.org/r/37655/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Joseph Wu > >
