----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37714/#review96849 -----------------------------------------------------------
Patch looks great! Reviews applied: [37714] All tests passed. - Mesos ReviewBot On Aug. 28, 2015, 8:11 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37714/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2015, 8:11 a.m.) > > > Review request for mesos, Joerg Schad, Michael Park, and Jan Schlicht. > > > Bugs: MESOS-2924 > https://issues.apache.org/jira/browse/MESOS-2924 > > > Repository: mesos > > > Description > ------- > > Adds extra template parameters to `multihashmap` which offer control over the > hash function to use as well as the equality operator. > > Implements initializer_list, copy and move constructors for both, > `multihashmap` and `Multimap` in a similar way as it was done for `hashmap` > and `hashset`. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp > d9e4031cee64e48ad50541c04ca11e7861d0a17c > 3rdparty/libprocess/3rdparty/stout/include/stout/multimap.hpp > fb3e7a1d0377001389980302342813217f49cf5f > 3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp > 535cd2d10e3074c86c149ce85b205e73ca42ddd3 > > Diff: https://reviews.apache.org/r/37714/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >