> On Aug. 28, 2015, 7:59 p.m., Jie Yu wrote: > > src/slave/flags.cpp, lines 72-76 > > <https://reviews.apache.org/r/37881/diff/1/?file=1057726#file1057726line72> > > > > Why do you still need this flag? > > Jiang Yan Xu wrote: > We instantiate all supported backends but this flag specifies the user's > choice for new images. I don't think we can make a perfect guess based soley > on system compatibility: what if the user only has small images and don't > have the mount point created? > > Jie Yu wrote: > User does not care which backend we use, right? We just pick a backend > that works. If there are multiple supported backend, just pick the one that's > the best. > > The flag is a little wiered to me because what if bind backend is not > supported but copy backend is supported, the user specifes the backend to be > bind, should we fail, or fall back to the copy backend? I think we can punt > on this flag for now since we only have one backend right now. > > Jiang Yan Xu wrote: > Sorry I meant the operator and the image in the default container info: > If the operator just downloads an Appc image from the interenet which doesn't > have the mountpoint for BindBackend but he does't have the choice to choose > CopyBackend instead (which we should add soon)..
OK, I think that's fine. Not a big deal. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37881/#review96903 ----------------------------------------------------------- On Aug. 28, 2015, 9:04 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37881/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2015, 9:04 a.m.) > > > Review request for mesos, Jie Yu and Timothy Chen. > > > Bugs: MESOS-2796 > https://issues.apache.org/jira/browse/MESOS-2796 > > > Repository: mesos > > > Description > ------- > > Implemented AppcProvisioner. > > > Diffs > ----- > > src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 > src/slave/containerizer/provisioner.cpp > efc7e6996ff6663bebaf61989a7e040bd2ad7a5e > src/slave/containerizer/provisioners/appc.hpp PRE-CREATION > src/slave/containerizer/provisioners/appc.cpp PRE-CREATION > src/slave/containerizer/provisioners/appc/paths.hpp > 41e3bf79da0854406c488855f953111e67353829 > src/slave/containerizer/provisioners/appc/paths.cpp > 3113c84b9526dd9e9e89fb9aa4ec75ed66a996c7 > src/slave/flags.hpp e56738e2dfd6593ef8f093687919da287af78f77 > src/slave/flags.cpp b36710d6d7a7250bc071a57310a2d54bfb3bc624 > src/tests/containerizer/appc_provisioner_tests.cpp > 47b66b9c30cefe8f9a8e2c1c1341776c2d235020 > > Diff: https://reviews.apache.org/r/37881/diff/ > > > Testing > ------- > > sudo make check. > > More test cases coming. > > > Thanks, > > Jiang Yan Xu > >
