> On Aug. 28, 2015, 12:59 p.m., Jie Yu wrote: > > src/slave/containerizer/provisioner.cpp, lines 43-46 > > <https://reviews.apache.org/r/37881/diff/1/?file=1057720#file1057720line43> > > > > I would love to get this TODO solved in this patch. It should be pretty > > straightfoward, right? Just hard code them. And right now, only Appc is > > supported. > > Jiang Yan Xu wrote: > Fine with me. > > Jiang Yan Xu wrote: > I have changed the semantics to Provisioner::create to this: > > ``` > // Create all supported provisioners. Return error if provisioners > // explicitly specified in '--provisioners' have failed to be created. > ``` > > So we still need the flag. > > The reason is that let's say the AppcProvisioner::create() somehow fails > while DockerProvisioner::create() succeeds but the operator intends to make > sure Appc works within the cluster. He probably wants the slave to fail so he > can fix the box rather than waiting until tasks shown as LOST much later. The > default for `--provisioners` is empty so there is no burden on the operator > if they don't care about this. > > Jie Yu wrote: > Hum, that semantics is even more weired. If that's the case, I would > rather stick to the original semantics: only creates provisioner that's > specified by the operator and fails if any of them fails to be created. What > do you think?
SG. In fact, on second thought, we cannot reliably detect which provisioners "is supported" because it requires image-related infra to be set up for the cluster! It's not a local decision to make and we should rely on the operator's explict intention for this. - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37881/#review96903 ----------------------------------------------------------- On Aug. 29, 2015, 9:28 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37881/ > ----------------------------------------------------------- > > (Updated Aug. 29, 2015, 9:28 p.m.) > > > Review request for mesos, Jie Yu and Timothy Chen. > > > Bugs: MESOS-2796 > https://issues.apache.org/jira/browse/MESOS-2796 > > > Repository: mesos > > > Description > ------- > > Implemented AppcProvisioner. > > > Diffs > ----- > > src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 > src/slave/containerizer/provisioner.hpp > 541dd4e0b2f0c92a45c00cab6132a2be69654838 > src/slave/containerizer/provisioner.cpp > efc7e6996ff6663bebaf61989a7e040bd2ad7a5e > src/slave/containerizer/provisioners/appc.hpp PRE-CREATION > src/slave/containerizer/provisioners/appc.cpp PRE-CREATION > src/slave/containerizer/provisioners/appc/paths.hpp > 41e3bf79da0854406c488855f953111e67353829 > src/slave/containerizer/provisioners/appc/paths.cpp > 3113c84b9526dd9e9e89fb9aa4ec75ed66a996c7 > src/slave/flags.hpp e56738e2dfd6593ef8f093687919da287af78f77 > src/slave/flags.cpp b36710d6d7a7250bc071a57310a2d54bfb3bc624 > src/tests/containerizer/appc_provisioner_tests.cpp > 47b66b9c30cefe8f9a8e2c1c1341776c2d235020 > > Diff: https://reviews.apache.org/r/37881/diff/ > > > Testing > ------- > > sudo make check. > > More test cases coming. > > > Thanks, > > Jiang Yan Xu > >
